WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
176680
webkitbot should recognize commands even when colon is omitted
https://bugs.webkit.org/show_bug.cgi?id=176680
Summary
webkitbot should recognize commands even when colon is omitted
Ryosuke Niwa
Reported
2017-09-10 19:51:32 PDT
Right now, webkitbot doesn't recognize a command when : is omitted as in: webkitbot rollout
r999999
introduced a build failure Fix this, and also enhance "hi!" command so that it can respond with "hi!" even when the bot name is omitted.
Attachments
Fixe the bug
(1.26 KB, patch)
2017-09-10 19:54 PDT
,
Ryosuke Niwa
dbates
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2017-09-10 19:51:44 PDT
<
rdar://problem/29933898
>
Ryosuke Niwa
Comment 2
2017-09-10 19:54:41 PDT
Created
attachment 320414
[details]
Fixe the bug Actually, let's do "hi!" enhancement in a aspirate patch since the bug fix is one liner.
Daniel Bates
Comment 3
2017-09-11 09:20:11 PDT
Comment on
attachment 320414
[details]
Fixe the bug View in context:
https://bugs.webkit.org/attachment.cgi?id=320414&action=review
> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92 > request = request.split(':', 1) > elif vocative_separator == ',': > request = request.split(',', 1) > + elif vocative_separator == ' ': > + request = request.split(' ', 1)
We could simplify this code by using an array and the "in" operator
Daniel Bates
Comment 4
2017-09-11 09:22:00 PDT
(In reply to Daniel Bates from
comment #3
)
> Comment on
attachment 320414
[details]
> Fixe the bug > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=320414&action=review
> > > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92 > > request = request.split(':', 1) > > elif vocative_separator == ',': > > request = request.split(',', 1) > > + elif vocative_separator == ' ': > > + request = request.split(' ', 1) > > We could simplify this code by using an array and the "in" operator
This is not necessary to do in this patch. Feel free to commit as-is/mark cq+.
Ryosuke Niwa
Comment 5
2017-09-11 11:55:31 PDT
(In reply to Daniel Bates from
comment #3
)
> Comment on
attachment 320414
[details]
> Fixe the bug > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=320414&action=review
> > > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92 > > request = request.split(':', 1) > > elif vocative_separator == ',': > > request = request.split(',', 1) > > + elif vocative_separator == ' ': > > + request = request.split(' ', 1) > > We could simplify this code by using an array and the "in" operator
That's a good point, let's do that.
Ryosuke Niwa
Comment 6
2017-09-11 16:28:27 PDT
Committed
r221892
: <
http://trac.webkit.org/changeset/221892
>
WebKit Commit Bot
Comment 7
2017-09-11 16:32:08 PDT
Re-opened since this is blocked by
bug 176752
Radar WebKit Bug Importer
Comment 8
2017-09-27 12:36:46 PDT
<
rdar://problem/34693601
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug