Bug 176680 – webkitbot should recognize commands even when colon is omitted

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

Right now, webkitbot doesn't recognize a command when : is omitted as in:
webkitbot rollout r999999 introduced a build failure

Fix this, and also enhance "hi!" command so that it can respond with "hi!" even when the bot name is omitted.

[Ryosuke Niwa]

<rdar://problem/29933898>

[Ryosuke Niwa]

Created attachment 320414 [details]
Fixe the bug

Actually, let's do "hi!" enhancement in a aspirate patch since the bug fix is one liner.

[Daniel Bates]

Comment on attachment 320414 [details]
Fixe the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=320414&action=review

> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92
>              request = request.split(':', 1)
>          elif vocative_separator == ',':
>              request = request.split(',', 1)
> +        elif vocative_separator == ' ':
> +            request = request.split(' ', 1)

We could simplify this code by using an array and the "in" operator

[Daniel Bates]

(In reply to Daniel Bates from comment #3)
> Comment on attachment 320414 [details]
> Fixe the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320414&action=review
> 
> > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92
> >              request = request.split(':', 1)
> >          elif vocative_separator == ',':
> >              request = request.split(',', 1)
> > +        elif vocative_separator == ' ':
> > +            request = request.split(' ', 1)
> 
> We could simplify this code by using an array and the "in" operator

This is not necessary to do in this patch. Feel free to commit as-is/mark cq+.

[Ryosuke Niwa]

(In reply to Daniel Bates from comment #3)
> Comment on attachment 320414 [details]
> Fixe the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320414&action=review
> 
> > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92
> >              request = request.split(':', 1)
> >          elif vocative_separator == ',':
> >              request = request.split(',', 1)
> > +        elif vocative_separator == ' ':
> > +            request = request.split(' ', 1)
> 
> We could simplify this code by using an array and the "in" operator

That's a good point, let's do that.

[Ryosuke Niwa]

Committed r221892: <http://trac.webkit.org/changeset/221892>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 176752

[Radar WebKit Bug Importer]

<rdar://problem/34693601>