Bug 176671 - Refactor Document::updateTitleElement to use traits instead of function pointers
Summary: Refactor Document::updateTitleElement to use traits instead of function pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-10 11:51 PDT by Darin Adler
Modified: 2017-09-27 12:32 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.54 KB, patch)
2017-09-10 11:54 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2017-09-10 11:51:55 PDT
Refactor Document::updateTitleElement to use traits instead of function pointers
Comment 1 Darin Adler 2017-09-10 11:54:08 PDT
Created attachment 320399 [details]
Patch
Comment 2 Darin Adler 2017-09-10 13:38:39 PDT
Seems like too much attention for a small amount of code, but I could not resist. Antti, maybe this is even better than the last version?
Comment 3 Antti Koivisto 2017-09-10 15:05:02 PDT
Comment on attachment 320399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320399&action=review

> Source/WebCore/dom/Document.cpp:1545
> +template<typename> struct TitleTraits;

I feel using templates to implement two not-very-complicated cases is bit much but it is an improvement.
Comment 4 WebKit Commit Bot 2017-09-10 15:18:03 PDT
Comment on attachment 320399 [details]
Patch

Clearing flags on attachment: 320399

Committed r221838: <http://trac.webkit.org/changeset/221838>
Comment 5 WebKit Commit Bot 2017-09-10 15:18:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:32:58 PDT
<rdar://problem/34693468>