Bug 176667 - REGRESSION: [GTK] Generated HTML API documentation is missing descriptions
Summary: REGRESSION: [GTK] Generated HTML API documentation is missing descriptions
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, Regression
Depends on:
Reported: 2017-09-10 02:15 PDT by Carlos Garcia Campos
Modified: 2017-09-10 23:14 PDT (History)
6 users (show)

See Also:

Patch (6.79 KB, patch)
2017-09-10 02:19 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-09-10 02:15:03 PDT
This is happening since we moved the implementation files to glib dirs. The generate-gtkdoc script assumes that header and implementation files are always in the same directory. To reduce the input we pass to gtk-doc we ignore cpp files for which there isn't a public header. The code to do this check doesn't consider cpp files in a different directory than the header file. It also assumes that header and cpp files have the same filename except for the extension, which is true in all cases but WebKitWebView that we have two files WebKitWebView.cpp and WebKitWebViewGtk.cpp.
You can see that we have been generating api docs without descriptions for some time:

Comment 1 Carlos Garcia Campos 2017-09-10 02:19:02 PDT
Created attachment 320391 [details]
Comment 2 Build Bot 2017-09-10 02:21:06 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2017-09-10 02:26:54 PDT
I've re-generated the docs for 2.17.92 after applying this patch:

Comment 4 Adrian Perez 2017-09-10 06:42:27 PDT
Comment on attachment 320391 [details]

Informal r+

Once we figure out how are we going to generate documentation for WPE, we
may need to do something similar adding the files with “WPE.cpp” suffix
(but we are not at that point just yet).
Comment 5 Michael Catanzaro 2017-09-10 08:23:20 PDT
Comment on attachment 320391 [details]

Well this is Tools/gtk/generate/gtkdoc, so we don't need to consider WPE here. We'll indeed have to add WPE support soon, and move the script to Tools/Scripts.
Comment 6 Carlos Garcia Campos 2017-09-10 23:14:34 PDT
Committed r221847: <http://trac.webkit.org/changeset/221847>