RESOLVED FIXED 176644
WebAssembly: Wasm::IndexOrName has a raw pointer to Name 
https://bugs.webkit.org/show_bug.cgi?id=176644
Summary WebAssembly: Wasm::IndexOrName has a raw pointer to Name
Filip Pizlo
Reported 2017-09-08 21:20:43 PDT
Since StackFrame can be kept around for a while (see Exception.h), we need that reference to be protected somehow.
Attachments
patch (25.87 KB, patch)
2017-10-31 21:48 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
patch (25.88 KB, patch)
2017-10-31 22:00 PDT, JF Bastien 		msaboff: review+
msaboff: commit-queue-
DetailsFormatted DiffDiff
patch (25.79 KB, patch)
2017-10-31 22:44 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-09-08 22:00:55 PDT
It can stick around longer than the WebAssembly module?
Filip Pizlo
Comment 2 2017-09-08 22:19:08 PDT
(In reply to JF Bastien from comment #1) > It can stick around longer than the WebAssembly module? Exception is an object. It can stick around for as long as the user likes.
JF Bastien
Comment 3 2017-10-31 21:48:21 PDT
Created attachment 325542 [details] patch
Build Bot
Comment 4 2017-10-31 21:50:50 PDT
Attachment 325542 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
JF Bastien
Comment 5 2017-10-31 22:00:46 PDT
Created attachment 325543 [details] patch Odd, looks like my compiler does return value optimization to move, but the bots do it to copy, and Ref hates that. Using RefPtr instead, since that's what I store to right after anyways.
Build Bot
Comment 6 2017-10-31 22:01:50 PDT
Attachment 325543 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 7 2017-10-31 22:15:38 PDT
Comment on attachment 325543 [details] patch r=me after build fixes.
JF Bastien
Comment 8 2017-10-31 22:44:49 PDT
Created attachment 325545 [details] patch Can't use include guards on Name / NameSection / IndexOrName because they're included in JSC Stack things, and the RefPtr needs to call their dtor.
Build Bot
Comment 9 2017-10-31 22:46:20 PDT
Attachment 325545 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2017-10-31 23:16:03 PDT
Comment on attachment 325545 [details] patch Clearing flags on attachment: 325545 Committed r224272: <https://trac.webkit.org/changeset/224272>
WebKit Commit Bot
Comment 11 2017-10-31 23:16:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-11-15 13:06:41 PST
<rdar://problem/35568809>
Note You need to log in before you can comment on or make changes to this bug.