Since StackFrame can be kept around for a while (see Exception.h), we need that reference to be protected somehow.
It can stick around longer than the WebAssembly module?
(In reply to JF Bastien from comment #1) > It can stick around longer than the WebAssembly module? Exception is an object. It can stick around for as long as the user likes.
Created attachment 325542 [details] patch
Attachment 325542 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325543 [details] patch Odd, looks like my compiler does return value optimization to move, but the bots do it to copy, and Ref hates that. Using RefPtr instead, since that's what I store to right after anyways.
Attachment 325543 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325543 [details] patch r=me after build fixes.
Created attachment 325545 [details] patch Can't use include guards on Name / NameSection / IndexOrName because they're included in JSC Stack things, and the RefPtr needs to call their dtor.
Attachment 325545 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325545 [details] patch Clearing flags on attachment: 325545 Committed r224272: <https://trac.webkit.org/changeset/224272>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35568809>