Bug 176642 - Add WKUIDelegatePrivate equivalent of WKPageUIClient's decidePolicyForGeolocationPermissionRequest
Summary: Add WKUIDelegatePrivate equivalent of WKPageUIClient's decidePolicyForGeoloca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-08 17:52 PDT by Alex Christensen
Modified: 2017-09-27 12:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.08 KB, patch)
2017-09-08 17:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.32 KB, patch)
2017-09-09 14:31 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (22.50 KB, patch)
2017-09-11 11:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-09-08 17:52:55 PDT 
Add WKUIDelegatePrivate equivalent of WKPageUIClient's decidePolicyForGeolocationPermissionRequest
Comment 1 Alex Christensen 2017-09-08 17:54:15 PDT 
Created attachment 320321 [details]
Patch
Comment 2 Alex Christensen 2017-09-09 14:31:56 PDT 
Created attachment 320358 [details]
Patch
Comment 3 Darin Adler 2017-09-10 14:54:57 PDT 
Comment on attachment 320358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320358&action=review

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:337
> +Function<void(bool)> UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest(WebKit::WebPageProxy&, WebKit::WebFrameProxy& frame, API::SecurityOrigin& securityOrigin, Function<void(bool)>&& completionHandler)

As I mentioned in the other patch, I see no reason for the return value. We pass in a reference to a completion handler, and we null it out / move it out if we call it, so no need to also move it into a return value.
Comment 4 Alex Christensen 2017-09-11 11:54:37 PDT 
Created attachment 320451 [details]
Patch
Comment 5 Build Bot 2017-09-11 11:55:34 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 Alex Christensen 2017-09-11 13:45:40 PDT 
http://trac.webkit.org/r221873
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:33:34 PDT 
<rdar://problem/34693485>