Bug 176638 - [Cocoa] Add a modern WKPreferences switch to disable WebRTC
Summary: [Cocoa] Add a modern WKPreferences switch to disable WebRTC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-08 16:48 PDT by mitz
Modified: 2017-09-26 16:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.67 KB, patch)
2017-09-26 11:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.68 KB, patch)
2017-09-26 11:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2017-09-08 16:48:28 PDT 
<rdar://problem/34335158>
We should have a modern equivalent of WKPreferencesSetPeerConnectionEnabled.
Comment 1 youenn fablet 2017-09-26 11:15:30 PDT 
Created attachment 321846 [details]
Patch
Comment 2 Tim Horton 2017-09-26 11:44:45 PDT 
Comment on attachment 321846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321846&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:105
> +@property (nonatomic, setter=_setPeerConnectionEnabled:) BOOL _peerConnectionEnabled WK_API_AVAILABLE(macosx(10.13), ios(11.0));

Given that they have shipped, I don't think this can possibly be available in 10.13 or 11.0. Use the WK_TBA magic.
Comment 3 youenn fablet 2017-09-26 11:47:50 PDT 
Created attachment 321852 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-26 16:35:44 PDT 
Comment on attachment 321852 [details]
Patch

Clearing flags on attachment: 321852

Committed r222533: <http://trac.webkit.org/changeset/222533>
Comment 5 WebKit Commit Bot 2017-09-26 16:35:46 PDT 
All reviewed patches have been landed.  Closing bug.