Bug 176635 - Web Inspector: make split console full width of view
Summary: Web Inspector: make split console full width of view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-08 15:26 PDT by Devin Rousso
Modified: 2017-10-14 11:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2017-09-08 15:29 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] split console expanded (204.33 KB, image/png)
2017-09-08 15:29 PDT, Devin Rousso
no flags Details
[Image] split console collapsed (116.43 KB, image/png)
2017-09-08 16:29 PDT, Devin Rousso
no flags Details
Patch (3.53 KB, patch)
2017-10-13 16:05 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] split console expanded (Resources) (579.79 KB, image/png)
2017-10-13 16:05 PDT, Devin Rousso
no flags Details
[Image] split console collapsed (Resources) (584.78 KB, image/png)
2017-10-13 16:06 PDT, Devin Rousso
no flags Details
[Image] split console collapsed (Elements) (554.80 KB, image/png)
2017-10-13 16:06 PDT, Devin Rousso
no flags Details
[Image] Regression (55.66 KB, image/png)
2017-10-14 11:18 PDT, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-09-08 15:26:17 PDT
Instead of limiting the split console's width to just the main content area (non-sidebar space), we should consider widening it to cover the entire width.  This way, if both sidebars are visible, the console is not as "squished".
Comment 1 Devin Rousso 2017-09-08 15:29:19 PDT
Created attachment 320310 [details]
Patch
Comment 2 Devin Rousso 2017-09-08 15:29:47 PDT
Created attachment 320311 [details]
[Image] split console expanded
Comment 3 Joseph Pecoraro 2017-09-08 16:23:45 PDT
What does it look like when collapsed?
Comment 4 Devin Rousso 2017-09-08 16:29:13 PDT
Created attachment 320313 [details]
[Image] split console collapsed
Comment 5 Joseph Pecoraro 2017-09-08 16:56:41 PDT
(In reply to Devin Rousso from comment #4)
> Created attachment 320313 [details]
> [Image] split console collapsed

I can't help but notice you chose the tab that has a single sidebar showing. This looks a little weird but it doesn't look too bad. It certainly breaks some of the aesthetics.
Comment 6 Matt Baker 2017-09-21 15:45:13 PDT
(In reply to Devin Rousso from comment #2)
> Created attachment 320311 [details]
> [Image] split console expanded

Our current filter bar placement probably prevents us from making this change as is. I like the full width console, but would have to give more thought to how to resolve the aesthetic issues.
Comment 7 Devin Rousso 2017-09-21 16:50:14 PDT
(In reply to Matt Baker from comment #6)
> (In reply to Devin Rousso from comment #2)
> > Created attachment 320311 [details]
> > [Image] split console expanded
> 
> Our current filter bar placement probably prevents us from making this
> change as is. I like the full width console, but would have to give more
> thought to how to resolve the aesthetic issues.
Do you mean the FilterBar in the NavigationSidebar, or the FilterBar present in the Console tab?  I'm assuming the former since the Console's FilterBar isn't visible in the split console currently.

How does this prevent the change?  I think the visual distinction (especially when the SplitConsole is collapsed) is quite clear.  There is a huge benefit of having a full width console, especially in a tab like Debugger where both Sidebar are very useful (Breakpoints and Scope Chain).
Comment 8 Timothy Hatcher 2017-10-13 09:32:08 PDT
Interesting. The white background on the filter bar in the styles sidebar should be grey to match the sidebar background color now that it does not line up with the console input bar.
Comment 9 Devin Rousso 2017-10-13 16:05:13 PDT
Created attachment 323759 [details]
Patch
Comment 10 Devin Rousso 2017-10-13 16:05:43 PDT
Created attachment 323760 [details]
[Image] split console expanded (Resources)
Comment 11 Devin Rousso 2017-10-13 16:06:02 PDT
Created attachment 323762 [details]
[Image] split console collapsed (Resources)
Comment 12 Devin Rousso 2017-10-13 16:06:18 PDT
Created attachment 323763 [details]
[Image] split console collapsed (Elements)
Comment 13 WebKit Commit Bot 2017-10-13 17:05:11 PDT
Comment on attachment 323759 [details]
Patch

Clearing flags on attachment: 323759

Committed r223310: <https://trac.webkit.org/changeset/223310>
Comment 14 WebKit Commit Bot 2017-10-13 17:05:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2017-10-13 17:06:10 PDT
<rdar://problem/34989944>
Comment 16 Nikita Vasilyev 2017-10-14 11:18:39 PDT
Created attachment 323811 [details]
[Image] Regression

This broke the class list container. Should be an easy fix.