Bug 176630 - REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots
Summary: REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-08 13:55 PDT by Ryan Haddad
Modified: 2017-09-27 12:33 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch. (3.98 KB, patch)
2017-09-12 12:42 PDT, Mark Lam
jfbastien: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-09-08 13:55:48 PDT
** The following JSC stress test failures have been introduced:
	stress/op_mod-ConstVar.js.misc-ftl-no-cjit
	stress/op_mod-VarConst.js.misc-ftl-no-cjit
	stress/op_mod-VarVar.js.misc-ftl-no-cjit

https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20%28Tests%29/builds/971
Comment 1 Ryan Haddad 2017-09-08 14:00:18 PDT
Looking at the regression range, this may be related to https://trac.webkit.org/changeset/221774/webkit
Comment 2 Ryan Haddad 2017-09-08 14:00:50 PDT
(In reply to Ryan Haddad from comment #1)
> Looking at the regression range, this may be related to
> https://trac.webkit.org/changeset/221774/webkit
*The regression range being r221773 - r221779
Comment 3 Mark Lam 2017-09-09 09:51:20 PDT
I'll break these tests into smaller chunks.
Comment 4 Ryan Haddad 2017-09-12 09:31:27 PDT
The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit):
https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/1476
Comment 5 Mark Lam 2017-09-12 09:50:06 PDT
(In reply to Ryan Haddad from comment #4)
> The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit):
> https://build.webkit.org/builders/Apple%20El%20Capitan%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/1476

These are for op_div (not op_mod).  Anyway, let me trying increasing their timeout allowance and see if that helps.
Comment 6 Ryan Haddad 2017-09-12 10:18:42 PDT
(In reply to Mark Lam from comment #5)
> (In reply to Ryan Haddad from comment #4)
> > The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit):
> > https://build.webkit.org/builders/Apple%20El%20Capitan%2032-
> > bit%20JSC%20%28BuildAndTest%29/builds/1476
> 
> These are for op_div (not op_mod).  Anyway, let me trying increasing their
> timeout allowance and see if that helps.
Oops, sorry for missing that detail.
Comment 7 Mark Lam 2017-09-12 12:42:57 PDT
Created attachment 320562 [details]
proposed patch.
Comment 8 JF Bastien 2017-09-12 12:44:17 PDT
Comment on attachment 320562 [details]
proposed patch.

r=me
Comment 9 Mark Lam 2017-09-12 12:47:35 PDT
Thanks for the review.  Landed in r221935: <http://trac.webkit.org/r221935>.
Comment 10 Radar WebKit Bug Importer 2017-09-27 12:33:53 PDT
<rdar://problem/34693492>