Bug 176619 - [GTK] Improve Ctrl+W and Ctrl+Q shortcuts in MiniBrowser
Summary: [GTK] Improve Ctrl+W and Ctrl+Q shortcuts in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-08 11:05 PDT by Michael Catanzaro
Modified: 2017-09-10 02:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.37 KB, patch)
2017-09-08 11:06 PDT, Michael Catanzaro
cgarcia: review+
Details | Formatted Diff | Diff
Patch (4.08 KB, patch)
2017-09-09 12:24 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (4.14 KB, patch)
2017-09-09 12:28 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-09-08 11:05:14 PDT
In MiniBrowser, Ctrl+W closes the entire browser, but it should close only a single tab. It's been broken since support for multiple tabs was added.
Comment 1 Michael Catanzaro 2017-09-08 11:06:08 PDT
Created attachment 320279 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-09-08 23:56:24 PDT
Comment on attachment 320279 [details]
Patch

Shouldn't we try close here too?
Comment 3 Michael Catanzaro 2017-09-09 08:01:36 PDT
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 320279 [details]
> Patch
> 
> Shouldn't we try close here too?

Um... yes. I wrote this patch first and didn't remember that try_close existed.

We should do it for Ctrl+Q as well.
Comment 4 Michael Catanzaro 2017-09-09 12:24:30 PDT
Created attachment 320352 [details]
Patch
Comment 5 Michael Catanzaro 2017-09-09 12:28:16 PDT
Created attachment 320353 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-10 02:54:35 PDT
Comment on attachment 320353 [details]
Patch

Clearing flags on attachment: 320353

Committed r221833: <http://trac.webkit.org/changeset/221833>
Comment 7 WebKit Commit Bot 2017-09-10 02:54:36 PDT
All reviewed patches have been landed.  Closing bug.