Bug 176582 - Web Inspector: Make Dashboard Timeline icon and Timeline tab icon more similar
Summary: Web Inspector: Make Dashboard Timeline icon and Timeline tab icon more similar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-07 21:24 PDT by Joseph Pecoraro
Modified: 2017-09-27 12:33 PDT (History)
8 users (show)

See Also:


Attachments
[IMAGE] Before (16.93 KB, image/png)
2017-09-07 21:24 PDT, Joseph Pecoraro
no flags Details
[IMAGE] After (13.32 KB, image/png)
2017-09-07 21:25 PDT, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix (1.43 KB, patch)
2017-09-07 21:26 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-07 21:24:29 PDT
Make Dashboard Timeline icon and Timeline tab icon more similar

The two clocks are showing different times!
Comment 1 Joseph Pecoraro 2017-09-07 21:24:54 PDT
Created attachment 320231 [details]
[IMAGE] Before
Comment 2 Joseph Pecoraro 2017-09-07 21:25:10 PDT
Created attachment 320232 [details]
[IMAGE] After
Comment 3 Joseph Pecoraro 2017-09-07 21:26:48 PDT
Created attachment 320234 [details]
[PATCH] Proposed Fix

I haven't checked Retina yet. I made the clock hands a little off-center so that the icon wouldn't look weird (too much empty space in the bottom right made it feel weird).
Comment 4 Timothy Hatcher 2017-09-08 01:41:04 PDT
Comment on attachment 320234 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320234&action=review

> Source/WebInspectorUI/UserInterface/Images/Time.svg:5
> +    <path fill="none" stroke="currentColor" d="M 8.5 4 L 8.5 9.5 L 5 9.5"/>

The 4 will likely be better as 3.5 still to avoid a blured line.
Comment 5 Joseph Pecoraro 2017-09-11 10:28:03 PDT
(In reply to Timothy Hatcher from comment #4)
> Comment on attachment 320234 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320234&action=review
> 
> > Source/WebInspectorUI/UserInterface/Images/Time.svg:5
> > +    <path fill="none" stroke="currentColor" d="M 8.5 4 L 8.5 9.5 L 5 9.5"/>
> 
> The 4 will likely be better as 3.5 still to avoid a blured line.

I didn't see a blurred line on either @1x or @2x. The length also works well, at 3.5 it feels a little unbalanced to me.
Comment 6 WebKit Commit Bot 2017-09-11 10:32:53 PDT
Comment on attachment 320234 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 320234

Committed r221861: <http://trac.webkit.org/changeset/221861>
Comment 7 WebKit Commit Bot 2017-09-11 10:32:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:33:46 PDT
<rdar://problem/34693489>