Bug 176582 – Web Inspector: Make Dashboard Timeline icon and Timeline tab icon more similar

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Make Dashboard Timeline icon and Timeline tab icon more similar

The two clocks are showing different times!

[Joseph Pecoraro]

Created attachment 320231 [details]
[IMAGE] Before

[Joseph Pecoraro]

Created attachment 320232 [details]
[IMAGE] After

[Joseph Pecoraro]

Created attachment 320234 [details]
[PATCH] Proposed Fix

I haven't checked Retina yet. I made the clock hands a little off-center so that the icon wouldn't look weird (too much empty space in the bottom right made it feel weird).

[Timothy Hatcher]

Comment on attachment 320234 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320234&action=review

> Source/WebInspectorUI/UserInterface/Images/Time.svg:5
> +    <path fill="none" stroke="currentColor" d="M 8.5 4 L 8.5 9.5 L 5 9.5"/>

The 4 will likely be better as 3.5 still to avoid a blured line.

[Joseph Pecoraro]

(In reply to Timothy Hatcher from comment #4)
> Comment on attachment 320234 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320234&action=review
> 
> > Source/WebInspectorUI/UserInterface/Images/Time.svg:5
> > +    <path fill="none" stroke="currentColor" d="M 8.5 4 L 8.5 9.5 L 5 9.5"/>
> 
> The 4 will likely be better as 3.5 still to avoid a blured line.

I didn't see a blurred line on either @1x or @2x. The length also works well, at 3.5 it feels a little unbalanced to me.

[WebKit Commit Bot]

Comment on attachment 320234 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 320234

Committed r221861: <http://trac.webkit.org/changeset/221861>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693489>