RESOLVED FIXED 176579
Introduce a RecordData for Cache to efficiently check whether it matches a corresponding request or not 
https://bugs.webkit.org/show_bug.cgi?id=176579
Summary Introduce a RecordData for Cache to efficiently check whether it matches a co...
youenn fablet
Reported 2017-09-07 19:10:27 PDT
This will be useful to store the information to check whether a record is matching before fully reading the record.
Attachments
Patch (17.33 KB, patch)
2017-09-07 19:22 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.26 KB, patch)
2017-09-12 15:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-09-07 19:22:09 PDT
Created attachment 320225 [details] Patch
Build Bot
Comment 2 2017-09-07 19:24:18 PDT
Attachment 320225 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2017-09-12 15:24:20 PDT
Comment on attachment 320225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320225&action=review > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46 > + uint64_t identifier { 0}; space
youenn fablet
Comment 4 2017-09-12 15:43:10 PDT
Created attachment 320573 [details] Patch for landing
youenn fablet
Comment 5 2017-09-12 15:43:36 PDT
Thanks for the review. (In reply to Alex Christensen from comment #3) > Comment on attachment 320225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320225&action=review > > > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46 > > + uint64_t identifier { 0}; > > space Done
Build Bot
Comment 6 2017-09-12 15:44:35 PDT
Attachment 320573 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2017-09-12 16:13:20 PDT
Comment on attachment 320573 [details] Patch for landing Clearing flags on attachment: 320573 Committed r221942: <http://trac.webkit.org/changeset/221942>
WebKit Commit Bot
Comment 8 2017-09-12 16:13:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-09-27 12:37:03 PDT
<rdar://problem/34693609>
Note You need to log in before you can comment on or make changes to this bug.