Bug 176579 - Introduce a RecordData for Cache to efficiently check whether it matches a corresponding request or not
Summary: Introduce a RecordData for Cache to efficiently check whether it matches a co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-07 19:10 PDT by youenn fablet
Modified: 2017-09-27 12:37 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.33 KB, patch)
2017-09-07 19:22 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (17.26 KB, patch)
2017-09-12 15:43 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-09-07 19:10:27 PDT 
This will be useful to store the information to check whether a record is matching before fully reading the record.
Comment 1 youenn fablet 2017-09-07 19:22:09 PDT 
Created attachment 320225 [details]
Patch
Comment 2 Build Bot 2017-09-07 19:24:18 PDT 
Attachment 320225 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-09-12 15:24:20 PDT 
Comment on attachment 320225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320225&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46
> +    uint64_t identifier { 0};

space
Comment 4 youenn fablet 2017-09-12 15:43:10 PDT 
Created attachment 320573 [details]
Patch for landing
Comment 5 youenn fablet 2017-09-12 15:43:36 PDT 
Thanks for the review.

(In reply to Alex Christensen from comment #3)
> Comment on attachment 320225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320225&action=review
> 
> > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46
> > +    uint64_t identifier { 0};
> 
> space

Done
Comment 6 Build Bot 2017-09-12 15:44:35 PDT 
Attachment 320573 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2017-09-12 16:13:20 PDT 
Comment on attachment 320573 [details]
Patch for landing

Clearing flags on attachment: 320573

Committed r221942: <http://trac.webkit.org/changeset/221942>
Comment 8 WebKit Commit Bot 2017-09-12 16:13:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-09-27 12:37:03 PDT 
<rdar://problem/34693609>