Bug 176576 – check-webkit-style shouldn't check *Prefix.cpp for [build/include_order]

• Status: NEW
• Component: Tools / Tests

[Yoshiaki Jitsukawa]

*Prefix.cpp file is supposed to include only its primary
header "*Prefix.h" (and not to include "config.h") thus 
the style checker shouldn't check the include order of 
the file so as not to report the following error:
 Found header this file implements before WebCore config.h. 
 Should be: config.h, primary header, blank line, and then
 alphabetically sorted.  [build/include_order] [4]

[Yoshiaki Jitsukawa]

Created attachment 320220 [details]
Patch

[Yoshiaki Jitsukawa]

(In reply to Yoshiaki Jitsukawa from comment #1)
> Created attachment 320220 [details]
> Patch

"Source/WebCore/PAL/PALPrefix.cpp" is added in advance for Bug 175542 - [PAL] Add PALPrefix to project

[Maciej Stachowiak]

Comment on attachment 320220 [details]
Patch

Seems like a good change. Unfortunately, this patch itself fails the style checker. Seems like everything in this file would fail the rule, so not sure why. r=me but please update fo the style checker issue before landing.

[Jonathan Bedard]

Comment on attachment 320220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320220&action=review

> Tools/Scripts/webkitpy/style/checker.py:252
> +    ([# *Prefix.cpp files don't follow the include order rules.

This actually isn't a rule we can easily (or rather, should) change, it's coming from the automatic Python style checker.

Seems like we should just make this line conform with the rule (which would entail adding a space after [ or putting the comment on a new line)