Bug 176563 – Augmented Inspector: Provide a way to inspect a DOM Node (DOM.inspect)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Augmented Inspector: Provide a way to inspect a DOM Node (DOM.inspect)

Augmented Agents don't have access to the Inspector domain so they can't send Inspector.inspect events with a RemoteObject. They do however have access to the DOM domain and control nodeIds, so lets provide a parallel DOM.inspect(nodeId).

[Joseph Pecoraro]

<rdar://problem/19639583>

[Joseph Pecoraro]

Created attachment 320174 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Normally I am adamant about writing a test for all protocol changes, but interestingly this is a protocol method that WebKit doesn't implement, but an Augmented JSContext exercises via the generated ObjC API:

    @interface RWIProtocolDOMDomainEventDispatcher : NSObject
    - (void)inspectWithNodeId:(int)nodeId;
    ...
    @end

I tested it manually. Maybe I can write a protocol test for this by supplying some kind of pre-canned response.

[Joseph Pecoraro]

Comment on attachment 320174 [details]
[PATCH] Proposed Fix

Yeah, I think I can write a test!

[Joseph Pecoraro]

Created attachment 320183 [details]
[PATCH] Proposed Fix

[Matt Baker]

Comment on attachment 320183 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320183&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:393
> +    var activatedToolTip = WI.UIString("Stop element selection (%s)").format(WI._inspectModeKeyboardShortcut.displayName);

let

[Joseph Pecoraro]

Comment on attachment 320183 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320183&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:393
>> +    var activatedToolTip = WI.UIString("Stop element selection (%s)").format(WI._inspectModeKeyboardShortcut.displayName);
> 
> let

Due to surrounding code this might actually cause an exception. It needs a more holistic var=>let conversion.

[WebKit Commit Bot]

Comment on attachment 320183 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 320183

Committed r221765: <http://trac.webkit.org/changeset/221765>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.