Bug 176561 - [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
Summary: [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-07 13:39 PDT by Myles C. Maxfield
Modified: 2017-09-27 12:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (92.74 KB, patch)
2017-09-07 13:49 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (93.24 KB, patch)
2017-09-07 14:01 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (93.40 KB, patch)
2017-09-07 14:20 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (96.47 KB, patch)
2017-09-07 14:32 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (96.64 KB, patch)
2017-09-07 14:38 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (99.07 KB, patch)
2017-09-07 14:45 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (99.40 KB, patch)
2017-09-07 15:25 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (99.98 KB, patch)
2017-09-07 15:36 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-09-07 13:39:26 PDT 
[PAL] Unify PlatformUserPreferredLanguages.h with Language.h
Comment 1 Myles C. Maxfield 2017-09-07 13:49:48 PDT 
Created attachment 320171 [details]
Patch
Comment 2 Myles C. Maxfield 2017-09-07 14:01:42 PDT 
Created attachment 320175 [details]
Patch
Comment 3 Myles C. Maxfield 2017-09-07 14:20:57 PDT 
Created attachment 320180 [details]
Patch
Comment 4 Myles C. Maxfield 2017-09-07 14:32:00 PDT 
Created attachment 320182 [details]
Patch
Comment 5 Myles C. Maxfield 2017-09-07 14:38:58 PDT 
Created attachment 320184 [details]
Patch
Comment 6 Brent Fulgham 2017-09-07 14:44:32 PDT 
Comment on attachment 320184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320184&action=review

This change looks good, but I think you need to update some GTK-specific files:

platform/text/enchant/TextCheckerEnchant.cpp:25:22: fatal error: Language.h: No such file or directory

r=me, but no cq+ because there are some missing include corrections.

> Source/WTF/wtf/CMakeLists.txt:233
> +    Language.cpp

Ha! You caught this. :-)
Comment 7 Brent Fulgham 2017-09-07 14:45:15 PDT 
WPE:

In file included from /home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp:35:0:
DerivedSources/ForwardingHeaders/WebCore/Language.h:1:39: fatal error: WebCore/platform/Language.h: No such file or directory
 #include "WebCore/platform/Language.h"
Comment 8 Myles C. Maxfield 2017-09-07 14:45:42 PDT 
Created attachment 320185 [details]
Patch
Comment 9 Myles C. Maxfield 2017-09-07 15:25:18 PDT 
Created attachment 320190 [details]
Patch for committing
Comment 10 Myles C. Maxfield 2017-09-07 15:36:44 PDT 
Created attachment 320191 [details]
Patch for committing
Comment 11 WebKit Commit Bot 2017-09-07 16:11:25 PDT 
Comment on attachment 320191 [details]
Patch for committing

Clearing flags on attachment: 320191

Committed r221768: <http://trac.webkit.org/changeset/221768>
Comment 12 WebKit Commit Bot 2017-09-07 16:11:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2017-09-27 12:39:14 PDT 
<rdar://problem/34693692>