Bug 176558 - DFG OSR exit value recovery may recover values beyond the bounds of the stack pointer.
Summary: DFG OSR exit value recovery may recover values beyond the bounds of the stack...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Reported: 2017-09-07 13:28 PDT by Mark Lam
Modified: 2017-09-07 13:29 PDT (History)
6 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-09-07 13:28:24 PDT
This means that the recovered values may be trashed by interrupts.  I discovered this when working on https://bugs.webkit.org/show_bug.cgi?id=175144, using the validation patch (https://bugs.webkit.org/attachment.cgi?id=319676) that compares the recovered stack and registers using the jit based OSR exits vs the probe based OSR exits.  The recovered values beyond the sp manifested as differences in my test (which is what drew my attention to them).  This feels like either:
1. the sp was not set correctly, or
2. we have no need to recovering those values.

However, I modified the test code to write 0xbadbeef0 into the recovered stack values that reside beyond sp, and found that this did not result in any crash or test failure (on Octane's pdfjs).  That suggests that those values are not needed.

Regardless, we should investigate why this is happening.