Bug 176557 – [WK2] Add C API to retrieve the originating page of a WKDownload

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Add C API to retrieve the original page of a WKDownload. This is the C API equivalent to _WKDownload.originatingWebView in ObjC.

[Radar WebKit Bug Importer]

<rdar://problem/34314776>

[Chris Dumez]

Created attachment 320177 [details]
Patch

[Alex Christensen]

Comment on attachment 320177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320177&action=review

> Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:102
> +    m_originatingPage = page ? page->createWeakPtr() : WeakPtr<WebPageProxy>();

will nullptr not work?

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:265
> +void PageClientImpl::handleDownloadRequest(DownloadProxy*)
>  {
> -    ASSERT_ARG(download, download);
> -    ASSERT([download->wrapper() isKindOfClass:[_WKDownload class]]);
> -    [static_cast<_WKDownload *>(download->wrapper()) setOriginatingWebView:m_webView];
>  }

It would be nice if we could remove this PageClient call completely and make all platforms do this the same way.  It seems like that's all GTK is doing here, and WPE is in progress.

[Chris Dumez]

Created attachment 320189 [details]
Patch

[Build Bot]

Attachment 320189 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/WeakPtr.h:95:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 320189 [details]
Patch

Clearing flags on attachment: 320189

Committed r221766: <http://trac.webkit.org/changeset/221766>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.