Bug 176547 - Web Inspector: Canvas RecordingAction tree outline virtualization is broken
Summary: Web Inspector: Canvas RecordingAction tree outline virtualization is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 174968
Blocks: WebInspectorCanvasRecording
  Show dependency tree / graph
 
Reported: 2017-09-07 11:09 PDT by Matt Baker
Modified: 2018-02-21 13:23 PST (History)
5 users (show)

See Also:

Attachments
[Image] Bug (722.49 KB, image/png)
2017-09-07 11:09 PDT, Matt Baker 		no flags Details
Patch (4.59 KB, patch)
2017-09-07 12:22 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Recording] Reduction (472.07 KB, application/json)
2017-09-07 12:24 PDT, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-09-07 11:09:18 PDT 
Created attachment 320141 [details]
[Image] Bug

Summary:
Canvas RecordingAction tree outline virtualization is broken.

Steps to Reproduce:
1. Take a long recording (a few thousand frames)
2. Expand frame folders, scroll around a bunch
3. Scroll back to the top of the tree
  => Large number of elements missing
Comment 1 Devin Rousso 2017-09-07 12:22:47 PDT 
Created attachment 320155 [details]
Patch
Comment 2 Devin Rousso 2017-09-07 12:24:52 PDT 
Created attachment 320156 [details]
[Recording] Reduction

Steps to Reproduce:
1. Import the attached file
2. Scroll to the bottom of the TreeOutline
3. Expand Frame 61
4. Expand Frame 60
  => All elements before Frame 60 are missing, and there is a large empty space after the last child of Frame 61

Captured from <https://mdn.github.io/canvas-raycaster/>.
Comment 3 Joseph Pecoraro 2017-09-07 12:28:26 PDT 
Comment on attachment 320155 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-09-07 13:55:53 PDT 
Comment on attachment 320155 [details]
Patch

Clearing flags on attachment: 320155

Committed r221756: <http://trac.webkit.org/changeset/221756>
Comment 5 WebKit Commit Bot 2017-09-07 13:55:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:34:59 PDT 
<rdar://problem/34693531>