Bug 176539 - Align FetchResponse and FetchRequest body handling
Summary: Align FetchResponse and FetchRequest body handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-07 10:31 PDT by youenn fablet
Modified: 2017-09-27 12:35 PDT (History)
9 users (show)

See Also:

Attachments
Patch (50.07 KB, patch)
2017-09-07 10:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.67 MB, application/zip)
2017-09-07 12:31 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.83 MB, application/zip)
2017-09-07 12:33 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1.49 MB, application/zip)
2017-09-07 12:50 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (2.15 MB, application/zip)
2017-09-07 13:05 PDT, Build Bot 		no flags Details
Patch (67.73 KB, patch)
2017-09-07 13:42 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (67.69 KB, patch)
2017-09-07 13:52 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-09-07 10:31:59 PDT 
For consistency.
We should also introduce formData getter to FetchRequest.
Comment 1 youenn fablet 2017-09-07 10:50:59 PDT 
Created attachment 320137 [details]
Patch
Comment 2 Build Bot 2017-09-07 12:31:46 PDT 
Comment on attachment 320137 [details]
Patch

Attachment 320137 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4476732

New failing tests:
imported/w3c/web-platform-tests/url/urlencoded-parser.html
Comment 3 Build Bot 2017-09-07 12:31:47 PDT 
Created attachment 320159 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-09-07 12:33:36 PDT 
Comment on attachment 320137 [details]
Patch

Attachment 320137 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4476716

New failing tests:
imported/w3c/web-platform-tests/url/urlencoded-parser.html
Comment 5 Build Bot 2017-09-07 12:33:38 PDT 
Created attachment 320160 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 youenn fablet 2017-09-07 12:44:17 PDT 
imported/w3c/web-platform-tests/url/urlencoded-parser.html is failing as it needs to be rebased, the call to formData is now throwing a NotSupported exception.
Comment 7 Build Bot 2017-09-07 12:50:56 PDT 
Comment on attachment 320137 [details]
Patch

Attachment 320137 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4476699

New failing tests:
imported/w3c/web-platform-tests/url/urlencoded-parser.html
Comment 8 Build Bot 2017-09-07 12:50:58 PDT 
Created attachment 320161 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 9 Build Bot 2017-09-07 13:05:18 PDT 
Comment on attachment 320137 [details]
Patch

Attachment 320137 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4476766

New failing tests:
imported/w3c/web-platform-tests/url/urlencoded-parser.html
Comment 10 Build Bot 2017-09-07 13:05:20 PDT 
Created attachment 320163 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 youenn fablet 2017-09-07 13:42:32 PDT 
Created attachment 320169 [details]
Patch
Comment 12 youenn fablet 2017-09-07 13:52:02 PDT 
Created attachment 320173 [details]
Patch
Comment 13 WebKit Commit Bot 2017-09-07 16:24:01 PDT 
Comment on attachment 320173 [details]
Patch

Clearing flags on attachment: 320173

Committed r221772: <http://trac.webkit.org/changeset/221772>
Comment 14 WebKit Commit Bot 2017-09-07 16:24:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2017-09-27 12:35:12 PDT 
<rdar://problem/34693537>