Bug 176508 – WebDriver: ensure we close all windows handles when closing the session

• Status: RESOLVED
• Resolution: FIXED
• Component: WebDriver

[Carlos Garcia Campos]

The spec says that when closing the session all top level browsing contexts should be closed. We are currently checking if we have an active top level browsing context and then we try to close it before trying with the rest. It can happen that we are in an inconsistent state, for example if the current top level browsing context has been closed by JavaScript or another action and the user didn't switch to another one before closing the session. In such case, closing the session will fail with NoSuchwindow and any other window open will not be closed. It's safer to always as for all window handles and close them, which is what the spec says too.

[Carlos Garcia Campos]

Created attachment 320110 [details]
Patch

[Carlos Garcia Campos]

Build failure in EWS has nothing to do with this patch, it failed to build the dependencies.

[Blaze Burg]

Comment on attachment 320110 [details]
Patch

r=me

Couldn't this still race with JS that closes or navigations a window somehow?

[Carlos Garcia Campos]

(In reply to Brian Burg from comment #3)
> Comment on attachment 320110 [details]
> Patch
> 
> r=me

Thanks!

> Couldn't this still race with JS that closes or navigations a window somehow?

Yes, I think it's quite unlikely that something happens after the quit command (the problem in this case was a window closed before the quit command), and we are getting the window list again after closing every window. But yes, it could still happen. I think we could simply ignore NoSuchWindow errors when closing the session, if we try to close a window and the window no longer exists, there's no reason to fail.

[Carlos Garcia Campos]

Committed r221808: <http://trac.webkit.org/changeset/221808>

[Radar WebKit Bug Importer]

<rdar://problem/34694066>