RESOLVED FIXED 176493
Remove new-run-webkit-httpd as it appears to be old 
https://bugs.webkit.org/show_bug.cgi?id=176493
Summary Remove new-run-webkit-httpd as it appears to be old
Joseph Pecoraro
Reported 2017-09-06 19:31:36 PDT
Remove new-run-webkit-httpd as it appears to be old. > # FIXME: currently this code only works with the Chromium ports and LigHTTPd. > # It should be made to work on all ports. It hits an error when I run it. I'll leave in other LigHTTPd code since it seemed like it might be used for Tools/Scripts testing code.
Attachments
[PATCH] Proposed Fix (5.03 KB, patch)
2017-09-06 19:32 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-09-06 19:32:00 PDT
Created attachment 320093 [details] [PATCH] Proposed Fix
Alexey Proskuryakov
Comment 2 2017-09-06 20:29:28 PDT
Comment on attachment 320093 [details] [PATCH] Proposed Fix It’s quite sad to keep underlying code in, but this is an improvement anyway
Joseph Pecoraro
Comment 3 2017-09-06 20:34:00 PDT
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 320093 [details] > [PATCH] Proposed Fix > > It’s quite sad to keep underlying code in, but this is an improvement anyway If I had any way to figure out if it was used or not I'd remove it. As it is I can barely understand the python code that uses it. I find it very hard to follow.
WebKit Commit Bot
Comment 4 2017-09-06 21:02:20 PDT
Comment on attachment 320093 [details] [PATCH] Proposed Fix Clearing flags on attachment: 320093 Committed r221715: <http://trac.webkit.org/changeset/221715>
WebKit Commit Bot
Comment 5 2017-09-06 21:02:21 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2017-09-07 09:14:11 PDT
What happens if you simply delete all functions with "lighttpd" in the name, and then all files that are solely devoted to this server implementation? From brief grepping, it looks like the only non-mechanical case is websocket_server.py, which for some reason uses http_server.Lighttpd - I expect that moving a few lines of code will eliminate it from inheritance chain.
Radar WebKit Bug Importer
Comment 7 2017-09-27 13:02:55 PDT
<rdar://problem/34694544>
Note You need to log in before you can comment on or make changes to this bug.