Bug 176491 – [WebGL] accelerated texImage2D for video doesn't respect flipY

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Dean Jackson]

If we use the GPU->GPU path for video into texImage2D, it fails if the FLIPY texture parameter is set.

This affects Vimeo360.

[Dean Jackson]

<rdar://problem/33833511>

[Dean Jackson]

Created attachment 320088 [details]
Patch

[Dean Jackson]

Committed r221762: <http://trac.webkit.org/changeset/221762>

[Darin Adler]

Comment on attachment 320088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320088&action=review

> Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:349
> +    ASSERT(context);

Any time we write this, we should be asking ourselves, "Why didn’t I make the argument a reference instead of a pointer that must never be null'?"

[Dean Jackson]

Comment on attachment 320088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320088&action=review

>> Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:349
>> +    ASSERT(context);
> 
> Any time we write this, we should be asking ourselves, "Why didn’t I make the argument a reference instead of a pointer that must never be null'?"

Good point. I'll fix this in a followup.

[Ryan Haddad]

It looks like LayoutTest webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html has become a flaky failure after this change:

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r221874%20(3522)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2F1.0.2%2Fconformance%2Ftextures%2Ftex-image-and-sub-image-2d-with-video.html

[Ryan Haddad]

(In reply to Ryan Haddad from comment #6)
> It looks like LayoutTest
> webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html
> has become a flaky failure after this change:
> 
> https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/
> r221874%20(3522)/results.html
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=webgl%2F1.0.2%2Fconformance%2Ftextures%2Ftex-
> image-and-sub-image-2d-with-video.html
I am able to reproduce this locally with:
run-webkit-tests webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html --iter=10

I cannot reproduce with r221759.

[Ryan Haddad]

Reverted r221762 for reason:

This change caused flakiness in a webgl LayoutTest.

Committed r221898: <http://trac.webkit.org/changeset/221898>

[Dean Jackson]

Landed again in 221932, with the test being fixed in 221933.

[Ryan Haddad]

(In reply to Dean Jackson from comment #9)
> Landed again in 221932, with the test being fixed in 221933.

The test is still flaky after the fix:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/4459
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2F1.0.2%2Fconformance%2Ftextures%2Ftex-image-and-sub-image-2d-with-video.html

[Jon Lee]

This was reverted again in 222069.

[Dean Jackson]

Committed r222197: <http://trac.webkit.org/changeset/222197>