Bug 176478 – bisect-builds started failing with invalid json

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Lucas Forschler]

the json retrieval portion of the API gateway recently started returning invalid json.
After doing some google searching, it turns out they limit it to 1000 'things' returned. This breaks our use case.

https://forums.aws.amazon.com/thread.jspa?messageID=702451&#702451

[Radar WebKit Bug Importer]

<rdar://problem/34293921>

[Lucas Forschler]

Apparently this has recently been documented here:
http://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html

[Lucas Forschler]

I have a fix that I'm iterating on now... basically we need to avoid using the foreach loop in the AWS body mapping template. Instead, I can just pass along the raw JSON without mapping it to a new output format.

[Lucas Forschler]

Created attachment 320135 [details]
Update the json parsing implementation

[Aakash Jain]

rs=me assuming it is tested properly.

It would be good to mention the links to AWS rest API v2 either in ChangeLog or in comments here.

[Lucas Forschler]

Note, I have bumped our REST API implementation from v1 to v2. This is to avoid breaking anything currently relying on v1. Note, there is nothing else currently using this tool at the moment, but this should be done moving forward as a good engineering practice.


old: REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v1/'
new: REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'

[Lucas Forschler]

Committed revision 221741.