Bug 176477 - Require LoggingHelper overrides to provide identifier
Summary: Require LoggingHelper overrides to provide identifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-06 15:01 PDT by Eric Carlson
Modified: 2017-09-08 11:25 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch. (58.45 KB, patch)
2017-09-06 15:09 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2017-09-06 15:01:59 PDT 
Require LoggingHelper overrides to provide an identifier instead of logging 'this'. Also get rid of "notice" log level, "info" seems to be enough.
Comment 1 Eric Carlson 2017-09-06 15:09:16 PDT 
Created attachment 320064 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2017-09-06 19:33:01 PDT 
Comment on attachment 320064 [details]
Proposed patch.

Clearing flags on attachment: 320064

Committed r221712: <http://trac.webkit.org/changeset/221712>
Comment 3 WebKit Commit Bot 2017-09-06 19:33:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-09-08 11:25:12 PDT 
<rdar://problem/34335104>