Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
Created attachment 320049 [details] Patch
Comment on attachment 320049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320049&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:5284 > +- (_WKRectEdge) _pinnedState No space after the ) > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:5289 > +- (_WKRectEdge) _rubberBandState etc. > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:5294 > +- (void) _setRubberBandState:(_WKRectEdge)state This really isn't state, I wonder if we should take this opportunity to rename it to rubberBandingEnabled or rubberBandableEdges (please no) or something :P > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:83 > +typedef NS_OPTIONS(NSInteger, _WKRectEdge) { It would be pretty nice if this were a NSRectEdge or UIRectEdge typedef, wouldn't it? As it stands people are going to have to do silly things to use this API where they probably have platform edges in their code.
Created attachment 320051 [details] Patch
Created attachment 320054 [details] Patch
http://trac.webkit.org/r221694
Reverted r221694 for reason: broke build Committed r221702: <http://trac.webkit.org/changeset/221702>
Created attachment 320066 [details] Patch
http://trac.webkit.org/r221707
<rdar://problem/34693736>
Comment on attachment 320066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320066&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:83 > +typedef NS_OPTIONS(NSInteger, _WKRectEdge) { Options should be NSUInteger. > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:252 > +@property (nonatomic, readonly) _WKRectEdge _pinnedState; > +@property (nonatomic, setter=_setRubberBandingEnabled:) _WKRectEdge _rubberBandingEnabled; Missing availability.