176472 – [Mac] Upstream QTKit-related WebKitSystemInterface functions

Bug 176472 - [Mac] Upstream QTKit-related WebKitSystemInterface functions

Summary: [Mac] Upstream QTKit-related WebKitSystemInterface functions

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andy Estes

URL:
Keywords:	InRadar

Depends on:	176614
Blocks:
	Show dependency tree / graph

Reported:	2017-09-06 11:37 PDT by Andy Estes
Modified:	2017-09-27 12:34 PDT (History)
CC List:	9 users (show)

See Also:

Attachments
Patch (33.21 KB, patch) 2017-09-06 11:39 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (33.38 KB, patch) 2017-09-06 13:04 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (33.34 KB, patch) 2017-09-07 09:42 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (33.27 KB, patch) 2017-09-07 09:53 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (33.32 KB, patch) 2017-09-07 10:31 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (33.84 KB, patch) 2017-09-07 10:53 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (33.77 KB, patch) 2017-09-07 11:47 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (34.35 KB, patch) 2017-09-07 15:42 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (34.33 KB, patch) 2017-09-07 15:55 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (34.30 KB, patch) 2017-09-07 16:07 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (34.39 KB, patch) 2017-09-11 09:58 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Estes 2017-09-06 11:37:38 PDT

[Mac] Upstream QTKit-related WebKitSystemInterface functions

Comment 1 Andy Estes 2017-09-06 11:39:02 PDT Comment hidden (obsolete)

Created attachment 320044 [details]
Patch

Comment 2 Build Bot 2017-09-06 11:40:53 PDT Comment hidden (obsolete)

Attachment 320044 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andy Estes 2017-09-06 13:04:53 PDT Comment hidden (obsolete)

Created attachment 320053 [details]
Patch

Comment 4 Build Bot 2017-09-06 13:07:18 PDT Comment hidden (obsolete)

Attachment 320053 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Andy Estes 2017-09-07 09:42:23 PDT Comment hidden (obsolete)

Created attachment 320120 [details]
Patch

Comment 6 Build Bot 2017-09-07 09:44:19 PDT Comment hidden (obsolete)

Attachment 320120 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Andy Estes 2017-09-07 09:53:55 PDT Comment hidden (obsolete)

Created attachment 320121 [details]
Patch

Comment 8 Build Bot 2017-09-07 09:55:16 PDT Comment hidden (obsolete)

Attachment 320121 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Andy Estes 2017-09-07 10:31:00 PDT Comment hidden (obsolete)

Created attachment 320129 [details]
Patch

Comment 10 Build Bot 2017-09-07 10:33:42 PDT Comment hidden (obsolete)

Attachment 320129 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Andy Estes 2017-09-07 10:53:29 PDT Comment hidden (obsolete)

Created attachment 320139 [details]
Patch

Comment 12 Build Bot 2017-09-07 10:55:55 PDT Comment hidden (obsolete)

Attachment 320139 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 13 Andy Estes 2017-09-07 11:47:17 PDT Comment hidden (obsolete)

Created attachment 320148 [details]
Patch

Comment 14 Build Bot 2017-09-07 11:49:59 PDT Comment hidden (obsolete)

Attachment 320148 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Andy Estes 2017-09-07 15:42:06 PDT Comment hidden (obsolete)

Created attachment 320192 [details]
Patch

Comment 16 Build Bot 2017-09-07 15:43:35 PDT Comment hidden (obsolete)

Attachment 320192 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:356:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:357:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 17 Andy Estes 2017-09-07 15:55:16 PDT Comment hidden (obsolete)

Created attachment 320195 [details]
Patch

Comment 18 Build Bot 2017-09-07 15:58:03 PDT Comment hidden (obsolete)

Attachment 320195 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:352:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 19 Andy Estes 2017-09-07 16:07:02 PDT Comment hidden (obsolete)

Created attachment 320199 [details]
Patch

Comment 20 Build Bot 2017-09-07 16:08:47 PDT Comment hidden (obsolete)

Attachment 320199 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:352:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 21 WebKit Commit Bot 2017-09-07 17:24:11 PDT Comment hidden (obsolete)

Comment on attachment 320199 [details]
Patch

Clearing flags on attachment: 320199

Committed r221773: <http://trac.webkit.org/changeset/221773>

Comment 22 WebKit Commit Bot 2017-09-07 17:24:13 PDT Comment hidden (obsolete)

All reviewed patches have been landed.  Closing bug.

Comment 23 WebKit Commit Bot 2017-09-08 10:07:28 PDT Comment hidden (obsolete)

Re-opened since this is blocked by bug 176614

Comment 24 Andy Estes 2017-09-11 09:58:53 PDT

Created attachment 320436 [details]
Patch

Comment 25 WebKit Commit Bot 2017-09-11 10:42:40 PDT

Comment on attachment 320436 [details]
Patch

Clearing flags on attachment: 320436

Committed r221863: <http://trac.webkit.org/changeset/221863>

Comment 26 WebKit Commit Bot 2017-09-11 10:42:42 PDT

All reviewed patches have been landed.  Closing bug.

Comment 27 Radar WebKit Bug Importer 2017-09-27 12:34:35 PDT

<rdar://problem/34693514>