RESOLVED FIXED176471
[Win] test-webkitpy test timeout_context_unittest is failing. 
https://bugs.webkit.org/show_bug.cgi?id=176471
Summary [Win] test-webkitpy test timeout_context_unittest is failing.
Per Arne Vollan
Reported 2017-09-06 11:05:34 PDT
Traceback (most recent call last): File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/common/timeout_context_unittest.py", line 47, in test_timeout_data self.assertGreater(time.time() + 1, tmp.data.alarm_time) AssertionError: 1504671591.995077 not greater than 1504671591.995077
Attachments
Patch (1.44 KB, patch)
2017-09-06 11:16 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-09-06 11:16:15 PDT
Created attachment 320042 [details] Patch
Jonathan Bedard
Comment 2 2017-09-06 11:57:53 PDT
What platform was this failing on? I'm really surprised this is an issue.
Per Arne Vollan
Comment 3 2017-09-06 12:05:14 PDT
(In reply to Jonathan Bedard from comment #2) > What platform was this failing on? > > I'm really surprised this is an issue. It is failing on Windows. Do you think differences in time(r) resolution can cause this?
Jonathan Bedard
Comment 4 2017-09-06 12:08:48 PDT
(In reply to Per Arne Vollan from comment #3) > (In reply to Jonathan Bedard from comment #2) > > What platform was this failing on? > > > > I'm really surprised this is an issue. > > It is failing on Windows. Do you think differences in time(r) resolution can > cause this? Looking closer at that test, yes. time(r) resolution could cause this. I'm less surprised now that I've looked closer. Unofficial R+ from me (No a reviewer yet).
Per Arne Vollan
Comment 5 2017-09-06 12:33:11 PDT
(In reply to Jonathan Bedard from comment #4) > (In reply to Per Arne Vollan from comment #3) > > (In reply to Jonathan Bedard from comment #2) > > > What platform was this failing on? > > > > > > I'm really surprised this is an issue. > > > > It is failing on Windows. Do you think differences in time(r) resolution can > > cause this? > > Looking closer at that test, yes. time(r) resolution could cause this. I'm > less surprised now that I've looked closer. > > Unofficial R+ from me (No a reviewer yet). Ok, thanks!
Brent Fulgham
Comment 6 2017-09-06 12:36:46 PDT
Comment on attachment 320042 [details] Patch r=me. I wish Windows had better time resolution!
Per Arne Vollan
Comment 7 2017-09-06 13:19:12 PDT
(In reply to Brent Fulgham from comment #6) > Comment on attachment 320042 [details] > Patch > > r=me. I wish Windows had better time resolution! Thanks for reviewing!
WebKit Commit Bot
Comment 8 2017-09-06 13:48:04 PDT
Comment on attachment 320042 [details] Patch Clearing flags on attachment: 320042 Committed r221700: <http://trac.webkit.org/changeset/221700>
WebKit Commit Bot
Comment 9 2017-09-06 13:48:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-09-27 13:03:02 PDT
<rdar://problem/34694550>
Note You need to log in before you can comment on or make changes to this bug.