Bug 176462 – Support caching of Response with a ReadableStream body

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Support caching of Response with a ReadableStream body

[youenn fablet]

Created attachment 320028 [details]
Patch

[Alex Christensen]

Comment on attachment 320028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320028&action=review

> Source/WebCore/bindings/js/ReadableStream.cpp:105
> +enum class Method { Locked, Disturbed };
> +template<Method method>

I think this should be two separate functions, or one with a function as a parameter.  Most of the function is what is different.  Making two functions wouldn't duplicate much code.

[youenn fablet]

Created attachment 320060 [details]
Patch for landing

[youenn fablet]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 320028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320028&action=review
> 
> > Source/WebCore/bindings/js/ReadableStream.cpp:105
> > +enum class Method { Locked, Disturbed };
> > +template<Method method>
> 
> I think this should be two separate functions, or one with a function as a
> parameter.  Most of the function is what is different.  Making two functions
> wouldn't duplicate much code.

Done

[WebKit Commit Bot]

Comment on attachment 320060 [details]
Patch for landing

Clearing flags on attachment: 320060

Committed r221704: <http://trac.webkit.org/changeset/221704>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693521>