Bug 176453 - [WPE] Add missing test expectations
Summary: [WPE] Add missing test expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-06 06:43 PDT by Ms2ger (he/him; ⌚ UTC+1/+2)
Modified: 2017-09-27 12:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (21.70 KB, patch)
2017-09-06 06:46 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff
Patch (20.92 KB, patch)
2017-09-06 09:06 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ms2ger (he/him; ⌚ UTC+1/+2) 2017-09-06 06:43:55 PDT
.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-09-06 06:46:44 PDT
Created attachment 320016 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-09-06 06:58:53 PDT
Comment on attachment 320016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320016&action=review

> LayoutTests/platform/wpe/fast/events/touch/touch-constructor-expected.txt:14
> +FAIL touch = new Touch({ identifier: 1, target: document.body }) should not throw exception. Threw exception TypeError: function is not a constructor (evaluating 'new Touch({ identifier: 1, target: document.body })').
> +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
> +

An expected result should (in theory) have not FAIL lines.

This test was skipped on GTK in bug 163858. We should do the same on the WPE expectations file
Comment 3 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-09-06 09:06:47 PDT
Created attachment 320026 [details]
Patch
Comment 4 Carlos Alberto Lopez Perez 2017-09-06 09:31:38 PDT
Comment on attachment 320026 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2017-09-06 10:02:17 PDT
Comment on attachment 320026 [details]
Patch

Clearing flags on attachment: 320026

Committed r221680: <http://trac.webkit.org/changeset/221680>
Comment 6 WebKit Commit Bot 2017-09-06 10:02:19 PDT
All reviewed patches have been landed.  Closing bug.