Bug 176431 - [Win] WebCore failed to build, InbandTextTrackPrivateAVF: base class undefined.
Summary: [Win] WebCore failed to build, InbandTextTrackPrivateAVF: base class undefined.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-05 16:29 PDT by Per Arne Vollan
Modified: 2017-09-06 13:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.37 KB, patch)
2017-09-05 16:39 PDT, Per Arne Vollan 		achristensen: review+
Details | Formatted Diff | Diff
Patch (13.21 KB, patch)
2017-09-06 08:40 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-09-05 16:29:34 PDT 
This happens only when building from the .proj project files.

webcore\platform\graphics\avfoundation\cf\InbandTextTrackPrivateAVCF.h(37): error C2504: 'InbandTextTrackPrivateAVF': base class undefined (compiling source file WebCore\platform\graphics\avfoundation\cf\InbandTextTrackPrivateAVCF.cpp).
Comment 1 Per Arne Vollan 2017-09-05 16:30:41 PDT 
<rdar://problem/34207262>
Comment 2 Per Arne Vollan 2017-09-05 16:39:52 PDT 
Created attachment 319954 [details]
Patch
Comment 3 Alex Christensen 2017-09-05 19:03:10 PDT 
Comment on attachment 319954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319954&action=review

> Source/WebCore/config.h:32
> +#if PLATFORM(WIN) && !USE(WINGDI)

!USE(WINGDI) is unnecessary.  The WinCE port of yesteryear used that.

> Source/WebCore/config.h:112
> +// FIXME: Move this to JavaScriptCore/wtf/Platform.h, which is where we define USE_AVFOUNDATION on the Mac.

We should just define USE_AVFOUNDATION in WebCore on Mac.  We've done it all wrong if JavaScriptCore depends on AVFoundation.
Comment 4 Per Arne Vollan 2017-09-06 08:40:12 PDT 
Created attachment 320021 [details]
Patch
Comment 5 Per Arne Vollan 2017-09-06 10:05:43 PDT 
Thanks for reviewing!
Comment 6 Per Arne Vollan 2017-09-06 13:11:25 PDT 
Committed r221693: <https://trac.webkit.org/changeset/221693/webkit>