Bug 176424 – [Win] Enable DatatransferItems in DRT.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Per Arne Vollan]

DataTransferItems are currently not enabled in DRT on Windows.

[Per Arne Vollan]

Created attachment 319938 [details]
Patch

[Brent Fulgham]

Comment on attachment 319938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319938&action=review

r=me, as long as we don't have shipping software that depends on IWebPreferencesPrivate5 having only two API points.

> Source/WebKitLegacy/win/WebPreferences.h:263
> +    virtual HRESULT STDMETHODCALLTYPE setDataTransferItemsEnabled(BOOL);

Can you confirm that IWebPreferencesPrivate5 is not currently shipping to users? If it is, we will need to make IWPP6. :-(

[Per Arne Vollan]

Created attachment 320065 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 319938 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319938&action=review
> 
> r=me, as long as we don't have shipping software that depends on
> IWebPreferencesPrivate5 having only two API points.
> 
> > Source/WebKitLegacy/win/WebPreferences.h:263
> > +    virtual HRESULT STDMETHODCALLTYPE setDataTransferItemsEnabled(BOOL);
> 
> Can you confirm that IWebPreferencesPrivate5 is not currently shipping to
> users? If it is, we will need to make IWPP6. :-(

I don't believe so, but to be on the safe side, I uploaded another patch for review which adds a new interface.

Thanks for reviewing!

[Brent Fulgham]

Comment on attachment 320065 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 320065 [details]
Patch

Clearing flags on attachment: 320065

Committed r221733: <http://trac.webkit.org/changeset/221733>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693655>