C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(268): error C2440: 'initializing': cannot convert from 'WTF::StringView' to 'WTF::String' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(268): note: No constructor could take the source type, or constructor overload resolution was ambiguous C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): error C2664: 'WTF::String WebCore::pathByAppendingComponent(const WTF::String &,const WTF::String &)': cannot convert argument 2 from 'const WTF::StringView' to 'const WTF::String &' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): note: Reason: cannot convert from 'const WTF::StringView' to 'const WTF::String' C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
Created attachment 319918 [details] Patch
Comment on attachment 319918 [details] Patch r=me.
Comment on attachment 319918 [details] Patch Thanks for reviewing!
Comment on attachment 319918 [details] Patch Clearing flags on attachment: 319918 Committed r221628: <http://trac.webkit.org/changeset/221628>
All reviewed patches have been landed. Closing bug.
Thanks for fixing!
(In reply to Chris Dumez from comment #6) > Thanks for fixing! No problem :)
<rdar://problem/34693568>