Bug 176348 - [iOS WK2] Add plumbing for WKContentView to ask the web process for additional drag items
Summary: [iOS WK2] Add plumbing for WKContentView to ask the web process for additiona...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 176421
  Show dependency tree / graph
 
Reported: 2017-09-04 22:16 PDT by Wenson Hsieh
Modified: 2017-09-05 19:41 PDT (History)
4 users (show)

See Also:

Attachments
First pass (41.27 KB, patch)
2017-09-04 23:40 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Tweak ChangeLog wording (41.41 KB, patch)
2017-09-05 08:44 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (41.38 KB, patch)
2017-09-05 12:50 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-09-04 22:16:24 PDT 
Work towards <rdar://problem/31144674>
Comment 1 Wenson Hsieh 2017-09-04 23:40:40 PDT 
Created attachment 319880 [details]
First pass
Comment 2 Wenson Hsieh 2017-09-05 08:44:20 PDT 
Created attachment 319900 [details]
Tweak ChangeLog wording
Comment 3 Wenson Hsieh 2017-09-05 09:18:21 PDT 
Comment on attachment 319900 [details]
Tweak ChangeLog wording

View in context: https://bugs.webkit.org/attachment.cgi?id=319900&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:634
> +void WebPage::requestAdditionalItemsForDragSession(const WebCore::IntPoint& clientPosition, const WebCore::IntPoint& globalPosition)

WebCore:: namespace prefixes shouldn't be necessary here, nor in WebPageProxy. I'll remove these (either here, or in the next patch in the sequence).
Comment 4 Wenson Hsieh 2017-09-05 12:50:52 PDT 
Created attachment 319928 [details]
Patch
Comment 5 Wenson Hsieh 2017-09-05 17:49:17 PDT 
(This is the second patch in the sequence -- final part here: https://bugs.webkit.org/show_bug.cgi?id=176421)
Comment 6 Wenson Hsieh 2017-09-05 19:13:00 PDT 
Comment on attachment 319928 [details]
Patch

Thanks Tim!
Comment 7 WebKit Commit Bot 2017-09-05 19:41:55 PDT 
Comment on attachment 319928 [details]
Patch

Clearing flags on attachment: 319928

Committed r221660: <http://trac.webkit.org/changeset/221660>
Comment 8 WebKit Commit Bot 2017-09-05 19:41:57 PDT 
All reviewed patches have been landed.  Closing bug.