Bug 176346 - Air should have a Vector of prologue generators instead of a HashMap representing an optional prologue generator
Summary: Air should have a Vector of prologue generators instead of a HashMap represen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-04 20:27 PDT by Saam Barati
Modified: 2017-09-27 12:38 PDT (History)
14 users (show)

See Also:

Attachments
patch (10.07 KB, patch)
2017-09-05 18:20 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (10.06 KB, patch)
2017-09-05 18:25 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-09-04 20:27:55 PDT 
See discussion in:
https://bugs.webkit.org/show_bug.cgi?id=175396
Comment 1 Saam Barati 2017-09-05 18:20:57 PDT 
Created attachment 319964 [details]
patch
Comment 2 Build Bot 2017-09-05 18:22:50 PDT 
Attachment 319964 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3Procedure.h:189:  The parameter name "numEntrypoints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2017-09-05 18:25:03 PDT 
Created attachment 319967 [details]
patch
Comment 4 Mark Lam 2017-09-06 13:30:25 PDT 
Comment on attachment 319967 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2017-09-06 14:04:28 PDT 
Comment on attachment 319967 [details]
patch

Clearing flags on attachment: 319967

Committed r221703: <http://trac.webkit.org/changeset/221703>
Comment 6 WebKit Commit Bot 2017-09-06 14:04:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:38:34 PDT 
<rdar://problem/34693668>