Bug 176331 – [JSC] Remove "malloc" and "free" from JSC/API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Remove "malloc" and "free" from JSC/API

[Yusuke Suzuki]

Created attachment 319852 [details]
Patch

[Build Bot]

Attachment 319852 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSWrapperMap.mm:303:  Use equivelent function in <wtf/ASCIICType.h> instead of the toupper() function.  [runtime/ctype_function] [4]
ERROR: Source/JavaScriptCore/API/ObjcRuntimeExtras.h:133:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 319866 [details]
Patch

[Build Bot]

Attachment 319866 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSWrapperMap.mm:303:  Use equivelent function in <wtf/ASCIICType.h> instead of the toupper() function.  [runtime/ctype_function] [4]
ERROR: Source/JavaScriptCore/API/ObjcRuntimeExtras.h:133:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 320023 [details]
Patch

[Build Bot]

Attachment 320023 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSWrapperMap.mm:302:  Use equivelent function in <wtf/ASCIICType.h> instead of the toupper() function.  [runtime/ctype_function] [4]
ERROR: Source/JavaScriptCore/API/JSValue.mm:1059:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 320025 [details]
Patch

[Build Bot]

Attachment 320025 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSWrapperMap.mm:302:  Use equivelent function in <wtf/ASCIICType.h> instead of the toupper() function.  [runtime/ctype_function] [4]
ERROR: Source/JavaScriptCore/API/JSValue.mm:1059:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Miller]

Comment on attachment 320025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320025&action=review

r=me. This is a nice cleanup patch!

> Source/JavaScriptCore/API/JSWrapperMap.mm:278
> +                property.getterName = @(attributes[i].value);

Wow, I didn't know there was a magic @ operator in Obj-C. Learn something new everyday!

[Darin Adler]

Comment on attachment 320025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320025&action=review

> Source/JavaScriptCore/API/JSWrapperMap.mm:302
> +    buffer[3] = toupper(*name);

Style checker is correct about this, should be using toASCIIUpper instead of toupper.

[Yusuke Suzuki]

Comment on attachment 320025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320025&action=review

>> Source/JavaScriptCore/API/JSWrapperMap.mm:302
>> +    buffer[3] = toupper(*name);
> 
> Style checker is correct about this, should be using toASCIIUpper instead of toupper.

OK, fixed. I was a bit worried about the difference between toupper and toASCIIUpper. But maybe, it is not a problem.

[Yusuke Suzuki]

Committed r221723: <http://trac.webkit.org/changeset/221723>

[Radar WebKit Bug Importer]

<rdar://problem/34693642>