Bug 176324 – Use StringView in DOMFileSystem::evaluatePath()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Use StringView in DOMFileSystem::evaluatePath() for performance.

[Chris Dumez]

Created attachment 319833 [details]
Patch

[Darin Adler]

Comment on attachment 319833 [details]
Patch

Seems like a good first step. But I think that virtualPathSegments and relativePathSegments can also be StringView, for example. And we can write a pathByAppendingComponents that takes StringView too.

[Chris Dumez]

(In reply to Darin Adler from comment #2)
> Comment on attachment 319833 [details]
> Patch
> 
> Seems like a good first step. But I think that virtualPathSegments and
> relativePathSegments can also be StringView, for example. And we can write a
> pathByAppendingComponents that takes StringView too.

This issue for virtualPathSegments is that StringView::split() does not return a Vector <StringView> but rather a StringView::SplitResult which I cannot modify (The current code relies on modifying the Vector.

[Darin Adler]

(In reply to Chris Dumez from comment #3)
> This issue for virtualPathSegments is that StringView::split() does not
> return a Vector <StringView> but rather a StringView::SplitResult

Here is how you turn a SplitResult into a vector:

    Vector<StringView> vector;
    for (auto substringView : overallStringView.split('/'))
        vector.append(substringView);

[WebKit Commit Bot]

Comment on attachment 319833 [details]
Patch

Clearing flags on attachment: 319833

Committed r221573: <http://trac.webkit.org/changeset/221573>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693652>