RESOLVED FIXED 176274
Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked 
https://bugs.webkit.org/show_bug.cgi?id=176274
Summary Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButto...
Alex Christensen
Reported 2017-09-02 01:25:09 PDT
Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked
Attachments
Patch (16.85 KB, patch)
2017-09-02 01:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (16.87 KB, patch)
2017-09-04 21:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (16.84 KB, patch)
2017-09-04 22:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-02 01:25:57 PDT
Created attachment 319709 [details] Patch
Darin Adler
Comment 2 2017-09-02 10:56:37 PDT
Comment on attachment 319709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319709&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:120 > +#if !TARGET_OS_IOS I think this should be written in the affirmative, #if TARGET_OS_MAC (whatever the right name for that is), because the default for any new target should be no plugins. Also, in the past I thought the official name was "plug-in", not "plugin", and therefore the "I" would be capitalized in public identifiers like _plugInsEnabled.
Alex Christensen
Comment 3 2017-09-04 21:32:08 PDT
Created attachment 319873 [details] Patch
Alex Christensen
Comment 4 2017-09-04 22:14:48 PDT
Created attachment 319877 [details] Patch
Alex Christensen
Comment 5 2017-09-04 22:26:00 PDT
TARGET_OS_OSX didn't seem to work and it isn't used anywhere else. I changed it to !if !TARGET_OS_IPHONE which seems to mean just Mac, not phones, tablets, watches, tvs, or anything else so far.
Alex Christensen
Comment 6 2017-09-05 10:37:05 PDT
http://trac.webkit.org/r221621
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:53:31 PDT
<rdar://problem/34694218>
Note You need to log in before you can comment on or make changes to this bug.