Bug 176272 – Fix some style issues in the Web Process part of the Remote Layer Tree code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Fix some style issues in the Web Process part of the Remote Layer Tree code

[Tim Horton]

Created attachment 319700 [details]
Patch

[Tim Horton]

Not sure how I feel about the silly protector-name style nit, but if the bot enforces it I suppose we should follow it. The rest I wholly agree with.

Comment on attachment 319700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319700&action=review

> Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114
> +            dispatch_async(dispatch_get_main_queue(), ^ {

Very strange. I don’t seem to find a WebKit coding style guideline for blocks, and I believe the prevailing convention in WebKit is to omit the space. It looks like the script is applying a rule meant for something else to this block. Can you sidestep the issue by changing this into a lambda?

[Tim Horton]

(In reply to mitz from comment #3)
> Comment on attachment 319700 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319700&action=review
> 
> > Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114
> > +            dispatch_async(dispatch_get_main_queue(), ^ {
> 
> Very strange. I don’t seem to find a WebKit coding style guideline for
> blocks, and I believe the prevailing convention in WebKit is to omit the
> space. It looks like the script is applying a rule meant for something else
> to this block. Can you sidestep the issue by changing this into a lambda?

Ah, I've been tripped up by this before, and I think this warning has caused us to be super inconsistent. /Especially/ because the text of it uses the word "block".

Comment on attachment 319700 [details]
Patch

r=me with that space gone

[Tim Horton]

Created attachment 319708 [details]
Patch

[Tim Horton]

Created attachment 319712 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 319712 [details]
Patch

Clearing flags on attachment: 319712

Committed r221537: <http://trac.webkit.org/changeset/221537>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693689>