Bug 176272 - Fix some style issues in the Web Process part of the Remote Layer Tree code
Summary: Fix some style issues in the Web Process part of the Remote Layer Tree code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-02 00:47 PDT by Tim Horton
Modified: 2017-09-27 12:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.11 KB, patch)
2017-09-02 00:47 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (13.23 KB, patch)
2017-09-02 01:24 PDT, Tim Horton 		thorton: commit-queue+
Details | Formatted Diff | Diff
Patch (13.23 KB, patch)
2017-09-02 03:06 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-09-02 00:47:07 PDT 
Fix some style issues in the Web Process part of the Remote Layer Tree code
Comment 1 Tim Horton 2017-09-02 00:47:55 PDT 
Created attachment 319700 [details]
Patch
Comment 2 Tim Horton 2017-09-02 00:48:29 PDT 
Not sure how I feel about the silly protector-name style nit, but if the bot enforces it I suppose we should follow it. The rest I wholly agree with.
Comment 3 mitz 2017-09-02 01:03:39 PDT 
Comment on attachment 319700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319700&action=review

> Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114
> +            dispatch_async(dispatch_get_main_queue(), ^ {

Very strange. I don’t seem to find a WebKit coding style guideline for blocks, and I believe the prevailing convention in WebKit is to omit the space. It looks like the script is applying a rule meant for something else to this block. Can you sidestep the issue by changing this into a lambda?
Comment 4 Tim Horton 2017-09-02 01:04:39 PDT 
(In reply to mitz from comment #3)
> Comment on attachment 319700 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319700&action=review
> 
> > Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114
> > +            dispatch_async(dispatch_get_main_queue(), ^ {
> 
> Very strange. I don’t seem to find a WebKit coding style guideline for
> blocks, and I believe the prevailing convention in WebKit is to omit the
> space. It looks like the script is applying a rule meant for something else
> to this block. Can you sidestep the issue by changing this into a lambda?

Ah, I've been tripped up by this before, and I think this warning has caused us to be super inconsistent. /Especially/ because the text of it uses the word "block".
Comment 5 mitz 2017-09-02 01:23:04 PDT 
Comment on attachment 319700 [details]
Patch

r=me with that space gone
Comment 6 Tim Horton 2017-09-02 01:24:48 PDT 
Created attachment 319708 [details]
Patch
Comment 7 Tim Horton 2017-09-02 03:06:12 PDT 
Created attachment 319712 [details]
Patch
Comment 8 WebKit Commit Bot 2017-09-02 03:48:37 PDT 
Comment on attachment 319712 [details]
Patch

Clearing flags on attachment: 319712

Committed r221537: <http://trac.webkit.org/changeset/221537>
Comment 9 WebKit Commit Bot 2017-09-02 03:48:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-09-27 12:39:08 PDT 
<rdar://problem/34693689>