176271 – Move Web Process part of the Remote Layer Tree code out of a Mac-specific directory

RESOLVED FIXED 176271

Move Web Process part of the Remote Layer Tree code out of a Mac-specific directory

https://bugs.webkit.org/show_bug.cgi?id=176271

Summary Move Web Process part of the Remote Layer Tree code out of a Mac-specific dir...

Tim Horton

Reported 2017-09-02 00:36:27 PDT

Move Web Process part of the Remote Layer Tree code out of a Mac-specific directory

Attachments
Patch (322.05 KB, patch) 2017-09-02 00:38 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (324.51 KB, patch) 2017-09-02 01:17 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (325.62 KB, patch) 2017-09-02 01:41 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2017-09-02 00:38:10 PDT

Created attachment 319699 [details] Patch

Build Bot

Comment 2 2017-09-02 00:40:23 PDT Comment hidden (obsolete)

Attachment 319699 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.h:198: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteLayerTreeContext.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteScrollingCoordinator.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/GraphicsLayerCARemote.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.cpp:280: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.cpp:290: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.cpp:301: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.mm:603: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.mm:617: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.mm:631: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.mm:647: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteScrollingCoordinator.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteScrollingCoordinator.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:349: 'retainedPage' is incorrectly named. It should be named 'protector' or 'protectedWebPage'. [readability/naming/protected] [4] Total errors found: 17 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

mitz

Comment 3 2017-09-02 00:40:48 PDT

Comment on attachment 319699 [details] Patch rs=me

Tim Horton

Comment 4 2017-09-02 01:06:11 PDT

Anyone have thoughts about moving to WebProcess/WebPage/RemoteLayerTree instead? That would make it easier to parallel the UI process patch, which has platform-specific things in it (so then you can have UIProcess/RemoteLayerTree/ios instead of UIProcess/ios/RemoteLayerTree in addition to UIProcess/RemoteLayerTree -- locality is better in the former).

Tim Horton

Comment 5 2017-09-02 01:10:19 PDT

Weird, builds for me, but it ought not.

Tim Horton

Comment 6 2017-09-02 01:17:20 PDT

Created attachment 319706 [details] Patch

Build Bot

Comment 7 2017-09-02 01:19:55 PDT Comment hidden (obsolete)

Attachment 319706 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:603: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:617: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:631: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:647: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:198: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:280: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:290: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:301: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:349: 'retainedPage' is incorrectly named. It should be named 'protector' or 'protectedWebPage'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 17 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 8 2017-09-02 01:41:26 PDT

Created attachment 319710 [details] Patch

Build Bot

Comment 9 2017-09-02 01:44:26 PDT Comment hidden (obsolete)

Attachment 319710 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:603: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:617: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:631: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:647: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:198: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:280: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:290: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:301: 'layerProtector' is incorrectly named. It should be named 'protector' or 'protectedLayer'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:349: 'retainedPage' is incorrectly named. It should be named 'protector' or 'protectedWebPage'. [readability/naming/protected] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 17 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 10 2017-09-02 02:38:17 PDT

Comment on attachment 319710 [details] Patch Clearing flags on attachment: 319710 Committed r221536: <http://trac.webkit.org/changeset/221536>

WebKit Commit Bot

Comment 11 2017-09-02 02:38:19 PDT

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 12 2017-09-05 11:02:55 PDT

Comment on attachment 319710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319710&action=review > Source/WebKit/ChangeLog:15 > + * WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp. The WebPage directory doesn't really make any sense. Would it be better to parallel WebCore platform/ and do something like WebProcess/graphics/, WebProcess/scrolling/ ?

Tim Horton

Comment 13 2017-09-05 11:08:58 PDT

(In reply to Simon Fraser (smfr) from comment #12) > Comment on attachment 319710 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319710&action=review > > > Source/WebKit/ChangeLog:15 > > + * WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp. > > The WebPage directory doesn't really make any sense. Would it be better to > parallel WebCore platform/ and do something like WebProcess/graphics/, > WebProcess/scrolling/ ? The UI process and Shared directories have a lot of stuff directly in them, so maybe that is the place to go (just move up one level)... I'm not sure why historically stuff has gotten stuck inside WebProcess/WebPage/... in this patch I left it there because e.g. DrawingArea itself is in WebProcess/WebPage, and it didn't seem to make sense to move a DrawingArea subclass to a directory above the base class. We could follow WebCore... would we then fold e.g. the CoordinatedGraphics directory into WebProcess/graphics? (Mostly the motivation here was to get it out of mac/, but we can do more cleanup!)

Radar WebKit Bug Importer

Comment 14 2017-09-27 12:41:00 PDT

<rdar://problem/34693744>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Tim Horton

Reported

2017-09-02 00:36 PDT

Modified

2017-09-27 12:41 PDT History

CC List

6 users Show

URL

Keywords InRadar

Depends on

Blocks

173644

Dependencies

tree graph