Bug 176271 - Move Web Process part of the Remote Layer Tree code out of a Mac-specific directory
Summary: Move Web Process part of the Remote Layer Tree code out of a Mac-specific dir...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks: 173644
  Show dependency treegraph
 
Reported: 2017-09-02 00:36 PDT by Tim Horton
Modified: 2017-09-27 12:41 PDT (History)
6 users (show)

See Also:


Attachments
Patch (322.05 KB, patch)
2017-09-02 00:38 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (324.51 KB, patch)
2017-09-02 01:17 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (325.62 KB, patch)
2017-09-02 01:41 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-09-02 00:36:27 PDT
Move Web Process part of the Remote Layer Tree code out of a Mac-specific directory
Comment 1 Tim Horton 2017-09-02 00:38:10 PDT
Created attachment 319699 [details]
Patch
Comment 2 Build Bot 2017-09-02 00:40:23 PDT Comment hidden (obsolete)
Comment 3 mitz 2017-09-02 00:40:48 PDT
Comment on attachment 319699 [details]
Patch

rs=me
Comment 4 Tim Horton 2017-09-02 01:06:11 PDT
Anyone have thoughts about moving to WebProcess/WebPage/RemoteLayerTree instead? That would make it easier to parallel the UI process patch, which has platform-specific things in it (so then you can have UIProcess/RemoteLayerTree/ios instead of UIProcess/ios/RemoteLayerTree in addition to UIProcess/RemoteLayerTree -- locality is better in the former).
Comment 5 Tim Horton 2017-09-02 01:10:19 PDT
Weird, builds for me, but it ought not.
Comment 6 Tim Horton 2017-09-02 01:17:20 PDT
Created attachment 319706 [details]
Patch
Comment 7 Build Bot 2017-09-02 01:19:55 PDT Comment hidden (obsolete)
Comment 8 Tim Horton 2017-09-02 01:41:26 PDT
Created attachment 319710 [details]
Patch
Comment 9 Build Bot 2017-09-02 01:44:26 PDT Comment hidden (obsolete)
Comment 10 WebKit Commit Bot 2017-09-02 02:38:17 PDT
Comment on attachment 319710 [details]
Patch

Clearing flags on attachment: 319710

Committed r221536: <http://trac.webkit.org/changeset/221536>
Comment 11 WebKit Commit Bot 2017-09-02 02:38:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Simon Fraser (smfr) 2017-09-05 11:02:55 PDT
Comment on attachment 319710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319710&action=review

> Source/WebKit/ChangeLog:15
> +        * WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp.

The WebPage directory doesn't really make any sense. Would it be better to parallel WebCore platform/ and do something like WebProcess/graphics/, WebProcess/scrolling/ ?
Comment 13 Tim Horton 2017-09-05 11:08:58 PDT
(In reply to Simon Fraser (smfr) from comment #12)
> Comment on attachment 319710 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319710&action=review
> 
> > Source/WebKit/ChangeLog:15
> > +        * WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp.
> 
> The WebPage directory doesn't really make any sense. Would it be better to
> parallel WebCore platform/ and do something like WebProcess/graphics/,
> WebProcess/scrolling/ ?

The UI process and Shared directories have a lot of stuff directly in them, so maybe that is the place to go (just move up one level)... I'm not sure why historically stuff has gotten stuck inside WebProcess/WebPage/... in this patch I left it there because e.g. DrawingArea itself is in WebProcess/WebPage, and it didn't seem to make sense to move a DrawingArea subclass to a directory above the base class.

We could follow WebCore... would we then fold e.g. the CoordinatedGraphics directory into WebProcess/graphics?

(Mostly the motivation here was to get it out of mac/, but we can do more cleanup!)
Comment 14 Radar WebKit Bug Importer 2017-09-27 12:41:00 PDT
<rdar://problem/34693744>