Bug 176260 – REGRESSION (r219145): Toggling layer borders on a static document no longer works immediately

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

After r219145, toggling compositing layer borders, either via the Debug menu, or via the button in Web Inspector, no longer immediately hides or shows the layer borders. You have to reload the page, or trigger some other style recalc for the change to take effect.

[Radar WebKit Bug Importer]

<rdar://problem/34219966>

[Antti Koivisto]

Created attachment 330696 [details]
patch

[Antti Koivisto]

Created attachment 330701 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 330696 [details]
patch

I don't know if this i the right fix, and why it works. Layer borders are not painted; they are mapped to CA borders. And for layers with no backing store, setNeedsDisplay() is a no-op.

[Simon Fraser (smfr)]

Comment on attachment 330701 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330701&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:325
> +        m_layerNeedsCompositingUpdate = true;

Maybe we only need this part?

[Antti Koivisto]

(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 330701 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330701&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:325
> > +        m_layerNeedsCompositingUpdate = true;
> 
> Maybe we only need this part?

That's what I thought too but it doesn't work in MiniBrowser without also forcing paint. It is not clear to me what is supposed to make us paint.

[Antti Koivisto]

Safari and layout test are fine without the forced paint so I can land just that too.

[Antti Koivisto]

Actually Safari also needs forced paint to get repaint indicator right. Unlike borders that seems to be painted on top of the layer content.

[Antti Koivisto]

Created attachment 330710 [details]
patch

[Antti Koivisto]

Limited the repaint to the main layer that shows the counter.

[WebKit Commit Bot]

Comment on attachment 330710 [details]
patch

Clearing flags on attachment: 330710

Committed r226521: <https://trac.webkit.org/changeset/226521>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.