WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
176257
Add support for input.webkitEntries
https://bugs.webkit.org/show_bug.cgi?id=176257
Summary
Add support for input.webkitEntries
Chris Dumez
Reported
2017-09-01 16:40:36 PDT
Add support for input.webkitEntries: -
https://wicg.github.io/entries-api/#html-forms
Attachments
Patch
(53.92 KB, patch)
2017-09-05 14:16 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(53.93 KB, patch)
2017-09-05 14:21 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-09-01 16:41:07 PDT
<
rdar://problem/34218671
>
Chris Dumez
Comment 2
2017-09-05 14:16:35 PDT
Created
attachment 319933
[details]
Patch
Chris Dumez
Comment 3
2017-09-05 14:21:23 PDT
Created
attachment 319935
[details]
Patch
WebKit Commit Bot
Comment 4
2017-09-05 16:28:58 PDT
Comment on
attachment 319935
[details]
Patch Clearing flags on attachment: 319935 Committed
r221645
: <
http://trac.webkit.org/changeset/221645
>
WebKit Commit Bot
Comment 5
2017-09-05 16:28:59 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 6
2017-09-05 21:47:07 PDT
(In reply to WebKit Commit Bot from
comment #4
)
> Comment on
attachment 319935
[details]
> Patch > > Clearing flags on attachment: 319935 > > Committed
r221645
: <
http://trac.webkit.org/changeset/221645
>
The LayoutTest added with this change is failing on WK1: --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/forms/file/entries-api/drag-folder-webkitEntries-actual.txt @@ -16,9 +16,10 @@ PASS files[0].size is 5 PASS files[0].type is "text/plain" PASS files[1].name is "testFiles" -PASS files[1].size is 204 +FAIL files[1].size should be 204. Was 272. PASS files[1].type is "" PASS successfullyParsed is true +Some tests failed. TEST COMPLETE
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r221660%20(3437)/results.html
Chris Dumez
Comment 7
2017-09-05 22:00:37 PDT
(In reply to Ryan Haddad from
comment #6
)
> (In reply to WebKit Commit Bot from
comment #4
) > > Comment on
attachment 319935
[details]
> > Patch > > > > Clearing flags on attachment: 319935 > > > > Committed
r221645
: <
http://trac.webkit.org/changeset/221645
> > The LayoutTest added with this change is failing on WK1: > > --- > /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/ > forms/file/entries-api/drag-folder-webkitEntries-expected.txt > +++ > /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/ > forms/file/entries-api/drag-folder-webkitEntries-actual.txt > @@ -16,9 +16,10 @@ > PASS files[0].size is 5 > PASS files[0].type is "text/plain" > PASS files[1].name is "testFiles" > -PASS files[1].size is 204 > +FAIL files[1].size should be 204. Was 272. > PASS files[1].type is "" > PASS successfullyParsed is true > +Some tests failed. > > TEST COMPLETE > > >
https://build.webkit.org/results/
> Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r221660%20(3437)/results.html
Oh, I landed 2 patches around the same time and they apparently conflicted. Will fix shortly.
Chris Dumez
Comment 8
2017-09-05 22:03:01 PDT
(In reply to Chris Dumez from
comment #7
)
> (In reply to Ryan Haddad from
comment #6
) > > (In reply to WebKit Commit Bot from
comment #4
) > > > Comment on
attachment 319935
[details]
> > > Patch > > > > > > Clearing flags on attachment: 319935 > > > > > > Committed
r221645
: <
http://trac.webkit.org/changeset/221645
> > > The LayoutTest added with this change is failing on WK1: > > > > --- > > /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/ > > forms/file/entries-api/drag-folder-webkitEntries-expected.txt > > +++ > > /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/ > > forms/file/entries-api/drag-folder-webkitEntries-actual.txt > > @@ -16,9 +16,10 @@ > > PASS files[0].size is 5 > > PASS files[0].type is "text/plain" > > PASS files[1].name is "testFiles" > > -PASS files[1].size is 204 > > +FAIL files[1].size should be 204. Was 272. > > PASS files[1].type is "" > > PASS successfullyParsed is true > > +Some tests failed. > > > > TEST COMPLETE > > > > > >
https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r221660%20(3437)/results.html > > Oh, I landed 2 patches around the same time and they apparently conflicted. > Will fix shortly.
Rebaselined in <
http://trac.webkit.org/changeset/221663
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug