Bug 176257 - Add support for input.webkitEntries
Summary: Add support for input.webkitEntries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://wicg.github.io/entries-api/#h...
Keywords: InRadar
Depends on:
Blocks: 175976
  Show dependency treegraph
 
Reported: 2017-09-01 16:40 PDT by Chris Dumez
Modified: 2017-09-05 22:03 PDT (History)
5 users (show)

See Also:


Attachments
Patch (53.92 KB, patch)
2017-09-05 14:16 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (53.93 KB, patch)
2017-09-05 14:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-09-01 16:40:36 PDT
Add support for input.webkitEntries:
- https://wicg.github.io/entries-api/#html-forms
Comment 1 Radar WebKit Bug Importer 2017-09-01 16:41:07 PDT
<rdar://problem/34218671>
Comment 2 Chris Dumez 2017-09-05 14:16:35 PDT
Created attachment 319933 [details]
Patch
Comment 3 Chris Dumez 2017-09-05 14:21:23 PDT
Created attachment 319935 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-05 16:28:58 PDT
Comment on attachment 319935 [details]
Patch

Clearing flags on attachment: 319935

Committed r221645: <http://trac.webkit.org/changeset/221645>
Comment 5 WebKit Commit Bot 2017-09-05 16:28:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2017-09-05 21:47:07 PDT
(In reply to WebKit Commit Bot from comment #4)
> Comment on attachment 319935 [details]
> Patch
> 
> Clearing flags on attachment: 319935
> 
> Committed r221645: <http://trac.webkit.org/changeset/221645>
The LayoutTest added with this change is failing on WK1:

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/forms/file/entries-api/drag-folder-webkitEntries-actual.txt
@@ -16,9 +16,10 @@
 PASS files[0].size is 5
 PASS files[0].type is "text/plain"
 PASS files[1].name is "testFiles"
-PASS files[1].size is 204
+FAIL files[1].size should be 204. Was 272.
 PASS files[1].type is ""
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
 

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r221660%20(3437)/results.html
Comment 7 Chris Dumez 2017-09-05 22:00:37 PDT
(In reply to Ryan Haddad from comment #6)
> (In reply to WebKit Commit Bot from comment #4)
> > Comment on attachment 319935 [details]
> > Patch
> > 
> > Clearing flags on attachment: 319935
> > 
> > Committed r221645: <http://trac.webkit.org/changeset/221645>
> The LayoutTest added with this change is failing on WK1:
> 
> ---
> /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/
> forms/file/entries-api/drag-folder-webkitEntries-expected.txt
> +++
> /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/
> forms/file/entries-api/drag-folder-webkitEntries-actual.txt
> @@ -16,9 +16,10 @@
>  PASS files[0].size is 5
>  PASS files[0].type is "text/plain"
>  PASS files[1].name is "testFiles"
> -PASS files[1].size is 204
> +FAIL files[1].size should be 204. Was 272.
>  PASS files[1].type is ""
>  PASS successfullyParsed is true
> +Some tests failed.
>  
>  TEST COMPLETE
>  
> 
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r221660%20(3437)/results.html

Oh, I landed 2 patches around the same time and they apparently conflicted. Will fix shortly.
Comment 8 Chris Dumez 2017-09-05 22:03:01 PDT
(In reply to Chris Dumez from comment #7)
> (In reply to Ryan Haddad from comment #6)
> > (In reply to WebKit Commit Bot from comment #4)
> > > Comment on attachment 319935 [details]
> > > Patch
> > > 
> > > Clearing flags on attachment: 319935
> > > 
> > > Committed r221645: <http://trac.webkit.org/changeset/221645>
> > The LayoutTest added with this change is failing on WK1:
> > 
> > ---
> > /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/
> > forms/file/entries-api/drag-folder-webkitEntries-expected.txt
> > +++
> > /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/fast/
> > forms/file/entries-api/drag-folder-webkitEntries-actual.txt
> > @@ -16,9 +16,10 @@
> >  PASS files[0].size is 5
> >  PASS files[0].type is "text/plain"
> >  PASS files[1].name is "testFiles"
> > -PASS files[1].size is 204
> > +FAIL files[1].size should be 204. Was 272.
> >  PASS files[1].type is ""
> >  PASS successfullyParsed is true
> > +Some tests failed.
> >  
> >  TEST COMPLETE
> >  
> > 
> > https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r221660%20(3437)/results.html
> 
> Oh, I landed 2 patches around the same time and they apparently conflicted.
> Will fix shortly.

Rebaselined in <http://trac.webkit.org/changeset/221663>.