Bug 176249 – NetworkProcess Cache and Caches should be cleared when the last related WebProcess Cache or CacheStorage is destroyed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

This will allow getting rid of removed caches as early as possible.
This will also allow cleaning no longer used caches to optimize memory usage.

[youenn fablet]

Created attachment 319675 [details]
Patch

[Build Bot]

Attachment 319675 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h:49:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:164:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:169:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 319675 [details]
Patch

Attachment 319675 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4430218

New failing tests:
http/tests/cache-storage/cache-representation.https.html

[Build Bot]

Created attachment 319685 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[youenn fablet]

Created attachment 319936 [details]
Patch

[Build Bot]

Attachment 319936 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:164:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:169:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 319936 [details]
Patch

Attachment 319936 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4456648

New failing tests:
http/tests/cache-storage/cache-representation.https.html

[Build Bot]

Created attachment 319950 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[youenn fablet]

Created attachment 320055 [details]
Patch

[Build Bot]

Attachment 320055 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:164:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:169:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 320055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320055&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.h:68
> +    HashMap<PAL::SessionID, HashMap<uint64_t, uint64_t>> m_cachesReferences;

m_cacheReferences?
Also, could you typedef the uint64_t's so we can read what is going on here?

[youenn fablet]

Thanks for the review.

(In reply to Alex Christensen from comment #11)
> Comment on attachment 320055 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320055&action=review
> 
> > Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.h:68
> > +    HashMap<PAL::SessionID, HashMap<uint64_t, uint64_t>> m_cachesReferences;
> 
> m_cacheReferences?
> Also, could you typedef the uint64_t's so we can read what is going on here?

Let's rename to m_cachesLocks and add two uint64_t aliases CacheIdentifier and LockCount.

[youenn fablet]

Created attachment 320073 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 320073 [details]
Patch for landing

Clearing flags on attachment: 320073

Committed r221710: <http://trac.webkit.org/changeset/221710>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693867>