Bug 176241 – Do not Reject CacheStorage promises when updating the persistent filesystem data fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Instead, log an error in the console.

[youenn fablet]

Created attachment 319631 [details]
Patch

[youenn fablet]

Created attachment 319635 [details]
Patch

[Alex Christensen]

Comment on attachment 319635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319635&action=review

> Source/WebCore/Modules/cache/DOMCacheEngine.h:88
> +    template<class Decoder> static bool decode(Decoder&, CacheIdentifierOperationResult&);

This could return a std::optional<CacheIdentifierOperationResult>

[youenn fablet]

Thanks for the review.

(In reply to Alex Christensen from comment #3)
> Comment on attachment 319635 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319635&action=review
> 
> > Source/WebCore/Modules/cache/DOMCacheEngine.h:88
> > +    template<class Decoder> static bool decode(Decoder&, CacheIdentifierOperationResult&);
> 
> This could return a std::optional<CacheIdentifierOperationResult>

Yes, I plan to update these two decoders to the modern ones.
Note though that in the case it might be end up in more lines of code.

[WebKit Commit Bot]

Comment on attachment 319635 [details]
Patch

Rejecting attachment 319635 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 319635, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ebCore/Modules/cache/DOMCacheEngine.h
patching file Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp
patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4429024

[youenn fablet]

Created attachment 319654 [details]
Patch for landing

[youenn fablet]

Created attachment 319659 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 319659 [details]
Patch for landing

Clearing flags on attachment: 319659

Committed r221506: <http://trac.webkit.org/changeset/221506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693714>