Bug 176241 - Do not Reject CacheStorage promises when updating the persistent filesystem data fails
Summary: Do not Reject CacheStorage promises when updating the persistent filesystem d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-01 12:33 PDT by youenn fablet
Modified: 2017-09-27 12:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.49 KB, patch)
2017-09-01 12:43 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.57 KB, patch)
2017-09-01 13:01 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.43 KB, patch)
2017-09-01 15:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.60 KB, patch)
2017-09-01 15:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-09-01 12:33:08 PDT 
Instead, log an error in the console.
Comment 1 youenn fablet 2017-09-01 12:43:52 PDT 
Created attachment 319631 [details]
Patch
Comment 2 youenn fablet 2017-09-01 13:01:21 PDT 
Created attachment 319635 [details]
Patch
Comment 3 Alex Christensen 2017-09-01 15:00:33 PDT 
Comment on attachment 319635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319635&action=review

> Source/WebCore/Modules/cache/DOMCacheEngine.h:88
> +    template<class Decoder> static bool decode(Decoder&, CacheIdentifierOperationResult&);

This could return a std::optional<CacheIdentifierOperationResult>
Comment 4 youenn fablet 2017-09-01 15:14:39 PDT 
Thanks for the review.

(In reply to Alex Christensen from comment #3)
> Comment on attachment 319635 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319635&action=review
> 
> > Source/WebCore/Modules/cache/DOMCacheEngine.h:88
> > +    template<class Decoder> static bool decode(Decoder&, CacheIdentifierOperationResult&);
> 
> This could return a std::optional<CacheIdentifierOperationResult>

Yes, I plan to update these two decoders to the modern ones.
Note though that in the case it might be end up in more lines of code.
Comment 5 WebKit Commit Bot 2017-09-01 15:16:05 PDT 
Comment on attachment 319635 [details]
Patch

Rejecting attachment 319635 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 319635, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ebCore/Modules/cache/DOMCacheEngine.h
patching file Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp
patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4429024
Comment 6 youenn fablet 2017-09-01 15:27:46 PDT 
Created attachment 319654 [details]
Patch for landing
Comment 7 youenn fablet 2017-09-01 15:58:45 PDT 
Created attachment 319659 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-09-01 16:28:13 PDT 
Comment on attachment 319659 [details]
Patch for landing

Clearing flags on attachment: 319659

Committed r221506: <http://trac.webkit.org/changeset/221506>
Comment 9 WebKit Commit Bot 2017-09-01 16:28:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-09-27 12:39:50 PDT 
<rdar://problem/34693714>