Bug 176240 – Layout test http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Matt Lewis]

According to the dashboard http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html is a flaky failure on iOS simulator WK2.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fhandshake-ok-with-legacy-websocket-response-headers.html

build:
https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r221482%20(4031)/results.html
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/4031

diff:

--- /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer
 Test whether WebSocket handshake is OK with legacy response headers 'WebSocket-Location' and 'WebSocket-Origin'.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

[Matt Lewis]

Marked as flaky on iOS WK2

https://trac.webkit.org/changeset/222213/webkit

[Ryan Haddad]

This has also been seen on High Sierra Release WK2 with the same diff.

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r236943%20(7166)/results.html

[Shawn Roberts]

The following layout test is now flaky on Mojave Release. 

Previous flaky failures noted in iOS 10 Simulator WK2 debut and release, still happening as of today.

Command used to reproduce:

rwt --root testbuild-240473 http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html --iterations 500 -f

[Shawn Roberts]

Updated expectations for Mojave in https://trac.webkit.org/changeset/246111/webkit

[Radar WebKit Bug Importer]

<rdar://problem/51445000>

[Kate Cheney]

Created attachment 381973 [details]
Patch

[Kate Cheney]

Is anyone willing to r+? Can't reproduce this locally, it's not skipped in Test Expectations and it doesn't show up on the flakiness dashboard.

[WebKit Commit Bot]

Comment on attachment 381973 [details]
Patch

Rejecting attachment 381973 [details] from commit-queue.

New failing tests:
requestidlecallback/requestidlecallback-document-gc.html
Full output: https://webkit-queues.webkit.org/results/13201513

[WebKit Commit Bot]

Created attachment 382597 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Kate Cheney]

Created attachment 382598 [details]
Patch

[EWS]

Comment on attachment 382598 [details]
Patch

Rejecting attachment 382598 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 382598 [details]
Patch

Rejecting attachment 382598 [details] from commit-queue.

New failing tests:
requestidlecallback/requestidlecallback-document-gc.html
Full output: https://webkit-queues.webkit.org/results/13202288

[WebKit Commit Bot]

Created attachment 382640 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[David Kilzer (:ddkilzer)]

Committed r251949: <https://trac.webkit.org/changeset/251949>