Bug 176239 - Make PageClientImplCocoa a proper superclass of PageClientImpls for Mac and iOS
Summary: Make PageClientImplCocoa a proper superclass of PageClientImpls for Mac and iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-01 12:32 PDT by Alex Christensen
Modified: 2017-09-27 12:51 PDT (History)
3 users (show)

See Also:


Attachments
Patch (98.41 KB, patch)
2017-09-01 12:34 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (99.28 KB, patch)
2017-09-01 12:39 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (99.31 KB, patch)
2017-09-01 13:16 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-09-01 12:32:30 PDT
Make PageClientImplCocoa a proper superclass of PageClientImpls for Mac and iOS
Comment 1 Alex Christensen 2017-09-01 12:34:03 PDT
Created attachment 319629 [details]
Patch
Comment 2 Build Bot 2017-09-01 12:35:46 PDT
Attachment 319629 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.h:120:  The parameter name "layer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:180:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:403:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-09-01 12:39:31 PDT
Created attachment 319630 [details]
Patch
Comment 4 Alex Christensen 2017-09-01 13:16:23 PDT
Created attachment 319639 [details]
Patch
Comment 5 Alex Christensen 2017-09-01 15:19:40 PDT
http://trac.webkit.org/r221502
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:51:14 PDT
<rdar://problem/34694145>