As part of doing the WinCairo network process files ( https://bugs.webkit.org/show_bug.cgi?id=176069 ), we'd added a stubbed implementation of LegacyCustomProtocolManager to quiet warnings. There ( https://bugs.webkit.org/show_bug.cgi?id=176069#c4 ) it was suggested that we should not implement this for WinCairo, but LegacyCustomProtocolManager should only be included in the ports that are using it.
Created attachment 327991 [details] Make LegacyCustomProtocolManager optional for network process Make LegacyCustomProtocolManager optional for a port as we were asked to not provide it for WinCairo. Move it from the common file into the individual ports that are currently using it and put code behind a feature disabled for WinCairo. Uploading to test on the bots. Thanks to Shukuwa-san for working on this
Comment on attachment 327991 [details] Make LegacyCustomProtocolManager optional for network process Bots appear to be happy at least.
Comment on attachment 327991 [details] Make LegacyCustomProtocolManager optional for network process Woah, this is good, but it needs to be enabled on Cocoa platforms which don't use CMake.
Created attachment 328045 [details] Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes
Comment on attachment 328045 [details] Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes Clearing flags on attachment: 328045 Committed r225377: <https://trac.webkit.org/changeset/225377>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35788301>