Bug 176201 - download-latest-github-release.py should have friendlier output for non-404 errors
Summary: download-latest-github-release.py should have friendlier output for non-404 e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-31 17:22 PDT by Ross Kirsling
Modified: 2017-09-27 12:43 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.34 KB, patch)
2017-08-31 17:22 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2017-08-31 17:22:02 PDT
download-latest-github-release.py should have friendlier output for non-404 errors
Comment 1 Ross Kirsling 2017-08-31 17:22:58 PDT
Created attachment 319547 [details]
Patch
Comment 2 Ross Kirsling 2017-09-01 11:06:52 PDT
Example

Before:
  UnboundLocalError: local variable 'response' referenced before assignment 

After (e.g.):
  401 Unauthorized
  No release found!
Comment 3 Brent Fulgham 2017-09-01 11:09:08 PDT
Comment on attachment 319547 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-09-01 12:13:56 PDT
Comment on attachment 319547 [details]
Patch

Clearing flags on attachment: 319547

Committed r221491: <http://trac.webkit.org/changeset/221491>
Comment 5 WebKit Commit Bot 2017-09-01 12:13:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:43:55 PDT
<rdar://problem/34693844>