[Cocoa] Upstream CoreGraphics-related WebKitSystemInterface functions
Created attachment 319546 [details] Patch
Attachment 319546 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:158: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319550 [details] Patch
Attachment 319550 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319555 [details] Patch
Attachment 319555 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319567 [details] Patch
Attachment 319567 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319569 [details] Patch
Attachment 319569 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319570 [details] Patch
Attachment 319570 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319576 [details] Patch
Attachment 319576 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319577 [details] Patch
Attachment 319577 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319580 [details] Patch
Attachment 319580 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319581 [details] Patch
Attachment 319581 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319584 [details] Patch
Attachment 319584 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319595 [details] Patch
Attachment 319595 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319598 [details] Patch
Attachment 319598 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319602 [details] Patch
Attachment 319602 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319603 [details] Patch
Attachment 319603 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319606 [details] Patch
Attachment 319606 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319618 [details] Patch
Comment on attachment 319618 [details] Patch Clearing flags on attachment: 319618 Committed r221485: <http://trac.webkit.org/changeset/221485>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34693910>