Bug 176196 – Simplify compositing layer updating

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Simplify compositing layer updating

[Simon Fraser (smfr)]

Created attachment 319541 [details]
Patch

[Build Bot]

Comment on attachment 319541 [details]
Patch

Attachment 319541 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4420508

New failing tests:
tiled-drawing/background-transparency-toggle.html

[Build Bot]

Created attachment 319558 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 319541 [details]
Patch

Attachment 319541 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4420557

New failing tests:
scrollingcoordinator/ios/sync-layer-positions-after-scroll.html

[Build Bot]

Created attachment 319560 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Simon Fraser (smfr)]

Created attachment 321285 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 321285 [details]
Patch

Clearing flags on attachment: 321285

Committed r222254: <http://trac.webkit.org/changeset/222254>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This revision has caused the test fast/images/animated-gif-webkit-transform.html
to start timing out on all platforms at a high rate.

I was able to reproduce the failure with run-webkit-tests fast/images/ -f --guard-malloc --iterations=10 --no-retry-failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r222273%20(4605)/results.html

Diff:

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/fast/images/animated-gif-webkit-transform-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/fast/images/animated-gif-webkit-transform-actual.txt
@@ -1,18 +1,3 @@
-Test that animated images are correctly paused / resumed when translated in and out of view using -webkit-transform.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 81962)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS isFirstImagePaused() became false
-PASS isSecondImagePaused() became true
-PASS isFirstImagePaused() is false
-Translating images left so that first image is no longer visible, but second image is.
-PASS isFirstImagePaused() became true
-PASS isSecondImagePaused() became false
-Translating images right so that second image is no longer visible, but first image is.
-PASS isFirstImagePaused() became false
-PASS isSecondImagePaused() became true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

[WebKit Commit Bot]

Re-opened since this is blocked by bug 177267

[Simon Fraser (smfr)]

I think this was a performance regression because before the change, we only call RLB::updateGeomery on layers that get a style change, but after the change, we call it on all layers since we do a compositing tree walk every frame.

[Simon Fraser (smfr)]

Done as part of the incremental compositing changes.

[Radar WebKit Bug Importer]

<rdar://problem/46397204>