Bug 176194 - Reject promises in case of internal CacheStorage engine errors.
Summary: Reject promises in case of internal CacheStorage engine errors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-31 16:25 PDT by youenn fablet
Modified: 2017-09-27 12:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.94 KB, patch)
2017-08-31 16:42 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing for landing (16.99 KB, patch)
2017-09-01 10:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-08-31 16:25:59 PDT 
Currently we use debug ASSERT and we silently fail.
It might be better to reject promises.
Comment 1 youenn fablet 2017-08-31 16:42:10 PDT 
Created attachment 319539 [details]
Patch
Comment 2 youenn fablet 2017-09-01 09:48:00 PDT 
A follow-up patch might want to change a little bit the error handling in the engine.
In particular, when we experience a write disk error, the modification in the in-memory representation is already done.
In that case, we could:
- Wait for write disk completion to make the in-memory change. That seems risky.
- Log in the inspector console any WriteDisk error, but not reject promises for that type of error.
Comment 3 youenn fablet 2017-09-01 10:46:57 PDT 
Created attachment 319614 [details]
Rebasing for landing
Comment 4 WebKit Commit Bot 2017-09-01 11:16:19 PDT 
Comment on attachment 319614 [details]
Rebasing for landing

Clearing flags on attachment: 319614

Committed r221483: <http://trac.webkit.org/changeset/221483>
Comment 5 WebKit Commit Bot 2017-09-01 11:16:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:45:57 PDT 
<rdar://problem/34693908>