Bug 176193 - Element focus appearance update should be either immediate or a post-layout task
Summary: Element focus appearance update should be either immediate or a post-layout task
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-31 16:01 PDT by Andreas Kling
Modified: 2017-09-27 12:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.14 KB, patch)
2017-08-31 16:19 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (10.63 KB, patch)
2017-08-31 17:30 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-08-31 16:01:47 PDT 
We currently have a zero-timer hack for delaying an element's "focus appearance update" (mostly about scrolling into view if needed.)
This is code from the long-long-ago that tried to avoid calling into layout during attach().

In modern day WebKit, we should be able to do this immediately when layout is clean, and as a post-layout callback otherwise.
Comment 1 Andreas Kling 2017-08-31 16:19:59 PDT 
Created attachment 319538 [details]
Patch
Comment 2 Andreas Kling 2017-08-31 17:30:34 PDT 
Created attachment 319552 [details]
Patch
Comment 3 Antti Koivisto 2017-08-31 17:35:05 PDT 
r=me
Comment 4 WebKit Commit Bot 2017-08-31 18:17:20 PDT 
Comment on attachment 319552 [details]
Patch

Clearing flags on attachment: 319552

Committed r221464: <http://trac.webkit.org/changeset/221464>
Comment 5 WebKit Commit Bot 2017-08-31 18:17:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:52:51 PDT 
<rdar://problem/34694199>